8355773: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee

[plummercj]

In an effort go get rid of calls to Debugee.threadByName() or Debugee.threadByNameOrThrow(), I found that many tests store the thread being looked up in a static field of the debuggee. The test can fetch the ThreadReference from the static field instead of looking it up using APIs that rely on vm.allThreads().

Most of the changes take advantage of the following common pattern:

In the debugger:

String          threadName1 = "thread1";
thread1 = debuggee.threadByNameOrThrow(threadName1);

In the debuggee:

static Thread thread1 = null;
thread1 = JDIThreadFactory.newThread(new Thread1addcountfilter001a("thread1"));

Note that the static field name for the Thread is the same as the thread name. Thus we can easily switch from looking up by thread name to instead looking up by static field name since they both use the same name.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355773: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24935/head:pull/24935
$ git checkout pull/24935

Update a local copy of the PR:
$ git checkout pull/24935
$ git pull https://git.openjdk.org/jdk.git pull/24935/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24935

View PR using the GUI difftool:
$ git pr show -t 24935

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24935.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355773: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• dcffd9d: 8347471: Provide valid flags and mask in AccessFlag.Location
• 83d0bd8: 8355069: Allocation::check_out_of_memory() should support CheckUnhandledOops mode
• 1652948: 8355442: Reference field lambda forms with type casts are not generated
• ... and 72 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[plummercj]

This is one that was missed during the PR for #24867.

[plummercj]

Note the added lines in the debuggee below.

[plummercj]

Note the added lines in the debuggee below.

[mlbridge]

Webrevs

• 00: Full (1aa2edc8)

[sspitsyn]

Looks good.

[plummercj]

Thank you for the review Alex and Serguei!

/integrate

[openjdk]

Going to push as commit 50145bb.
Since your change was applied there have been 87 commits pushed to the master branch:

• 486acc0: 8355453: nsk.share.jdi.Debugee.waitingEvent() does not timeout properly
• 6612281: 8342886: Update MET timezone in TimeZoneNames files
• fbc4691: 8351565: Implement JEP 502: Stable Values (Preview)
• ... and 84 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 50145bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.