Skip to content

8351412: Add AVX-512 intrinsics for ML-KEM #24953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

8351412: Add AVX-512 intrinsics for ML-KEM #24953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ef7c73
8351412: Add AVX-512 intrinsics for ML-KEM
ferakocz Jan 10, 2025
c5c6449
Removed debugging changes.
ferakocz Apr 30, 2025
43455de
Eliminating some instructions from generate_kyber12To16_avx512() + fi…
ferakocz May 12, 2025
215b346
Restoring copyright notice on ML_KEM.java
ferakocz May 12, 2025
32571f3
Responding to comments by Sandhya.
ferakocz May 14, 2025
e4f3264
Response to review comment + loading constants with broadcast op.
ferakocz May 15, 2025
ea2152d
Added some comments.
ferakocz May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,6 @@ address generate_kyberNttMult_avx512(StubGenerator *stubgen,
// result (short[256]) = c_rarg0
// a (short[256]) = c_rarg1
// b (short[256]) = c_rarg2
// kyberConsts (short[40]) = c_rarg3
address generate_kyberAddPoly_2_avx512(StubGenerator *stubgen,
MacroAssembler *_masm) {

Expand Down Expand Up @@ -739,7 +738,6 @@ address generate_kyberAddPoly_2_avx512(StubGenerator *stubgen,
// a (short[256]) = c_rarg1
// b (short[256]) = c_rarg2
// c (short[256]) = c_rarg3
// kyberConsts (short[40]) = c_rarg4
address generate_kyberAddPoly_3_avx512(StubGenerator *stubgen,
MacroAssembler *_masm) {

Expand Down
3 changes: 1 addition & 2 deletions src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the file contains only copyright changes.

* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -1181,7 +1181,6 @@ static void implKyberAddPolyJava(short[] result, short[] a, short[] b) {
int r = a[m] + b[m] + ML_KEM_Q; // This makes r > - ML_KEM_Q
a[m] = (short) r;
}
mlKemBarrettReduce(a);
}

// Adds the polynomial b to a in place, i.e. (the modified) a will hold
Expand Down