8356030: RISC-V: enable (part of) BasicDoubleOpTest.java

[Hamlin-Li]

Hi,
Can you help to review this patch?
Originally, I was going to enable all test cases on riscv in this test file. But seems there was already a try to implement RoundDoubleModeV (which is IRNode.ROUND_DOUBLE_MODE_V) in #21164, but failed because of some performance regression.
So I'll just enable part of test cases in this pr.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356030: RISC-V: enable (part of) BasicDoubleOpTest.java (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewers without OpenJDK IDs

• @mhaessig (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24983/head:pull/24983
$ git checkout pull/24983

Update a local copy of the PR:
$ git checkout pull/24983
$ git pull https://git.openjdk.org/jdk.git pull/24983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24983

View PR using the GUI difftool:
$ git pr show -t 24983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24983.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356030: RISC-V: enable (part of) BasicDoubleOpTest.java

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• ddd07b1: 8356172: IdealGraphPrinter doesn't need ThreadCritical
• 614ba9f: 8356075: Support Shenandoah GC in JVMCI
• ecfaf35: 8356083: ZGC: Duplicate ZTestEntry symbols in gtests
• ... and 62 more: https://git.openjdk.org/jdk/compare/0cd0afb2b32abd77f6275cf34a499b5cb31f22b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (df331fc0)

[RealFYang]

LGTM. Thanks.

[mhaessig]

Looks good to me as well. I also ran some testing that passed fine.

[Hamlin-Li]

Thank you @RealFYang @mhaessig !

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit da004cb.
Since your change was applied there have been 93 commits pushed to the master branch:

• b5fd289: 8356310: compiler/print/TestPrintAssemblyDeoptRace.java fails with Improperly specified VM option 'DeoptimizeALot'
• 328715d: 8356187: TestJcmd.java may incorrectly parse podman version
• 5089583: 8356259: Lift basic -Xlog:jit* logging to "info" level
• ... and 90 more: https://git.openjdk.org/jdk/compare/0cd0afb2b32abd77f6275cf34a499b5cb31f22b5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit da004cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.