-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8356044: Use Double::hashCode and Long::hashCode in java.vm.ci.meta #24988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back swen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
/label remove graal |
|
@wenshao |
|
@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
keep alive |
|
@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@wenshao The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@wenshao This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Similar to #24959 and #24971 and #24987, AbstractProfiledItem/PrimitiveConstant in java.vm.ci.meta can also be simplified similarly.
Replace manual bitwise operations in hashCode implementations of java.vm.ci.meta.AbstractProfiledItem/java.vm.ci.meta.PrimitiveConstant with Long::hashCode/Double.hashCode.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24988/head:pull/24988$ git checkout pull/24988Update a local copy of the PR:
$ git checkout pull/24988$ git pull https://git.openjdk.org/jdk.git pull/24988/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24988View PR using the GUI difftool:
$ git pr show -t 24988Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24988.diff
Using Webrev
Link to Webrev Comment