Skip to content

Conversation

@wenshao
Copy link
Contributor

@wenshao wenshao commented May 1, 2025

Similar to #24959 and #24971 and #24987, AbstractProfiledItem/PrimitiveConstant in java.vm.ci.meta can also be simplified similarly.

Replace manual bitwise operations in hashCode implementations of java.vm.ci.meta.AbstractProfiledItem/java.vm.ci.meta.PrimitiveConstant with Long::hashCode/Double.hashCode.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356044: Use Double::hashCode and Long::hashCode in java.vm.ci.meta (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24988/head:pull/24988
$ git checkout pull/24988

Update a local copy of the PR:
$ git checkout pull/24988
$ git pull https://git.openjdk.org/jdk.git pull/24988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24988

View PR using the GUI difftool:
$ git pr show -t 24988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24988.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2025

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 1, 2025

@wenshao The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels May 1, 2025
@wenshao wenshao marked this pull request as ready for review May 1, 2025 17:30
@wenshao wenshao changed the title Use Double::hashCode & Long::hashCode in java.vm.ci.meta 8356044: Use Double::hashCode and Long::hashCode in java.vm.ci.meta May 1, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2025
@mlbridge
Copy link

mlbridge bot commented May 1, 2025

Webrevs

@wenshao
Copy link
Contributor Author

wenshao commented May 12, 2025

/label remove graal

@openjdk openjdk bot removed the graal graal-dev@openjdk.org label May 12, 2025
@openjdk
Copy link

openjdk bot commented May 12, 2025

@wenshao
The graal label was successfully removed.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wenshao
Copy link
Contributor Author

wenshao commented Jun 27, 2025

keep alive

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2025

@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wenshao
Copy link
Contributor Author

wenshao commented Jul 26, 2025

/touch

@openjdk
Copy link

openjdk bot commented Jul 26, 2025

@wenshao The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2025

@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2025

@wenshao This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant