Skip to content

8356051: Update SignatureUtil.java with the new KnownOIDs#24993

Closed
wangweij wants to merge 1 commit intoopenjdk:masterfrom
wangweij:8356051
Closed

8356051: Update SignatureUtil.java with the new KnownOIDs#24993
wangweij wants to merge 1 commit intoopenjdk:masterfrom
wangweij:8356051

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented May 2, 2025

Fix the build error.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356051: Update SignatureUtil.java with the new KnownOIDs (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24993/head:pull/24993
$ git checkout pull/24993

Update a local copy of the PR:
$ git checkout pull/24993
$ git pull https://git.openjdk.org/jdk.git pull/24993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24993

View PR using the GUI difftool:
$ git pr show -t 24993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24993.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2025

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2025

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356051: Update SignatureUtil.java with the new KnownOIDs

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2025
@openjdk
Copy link

openjdk bot commented May 2, 2025

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 2, 2025
@mlbridge
Copy link

mlbridge bot commented May 2, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2025
@wangweij
Copy link
Contributor Author

wangweij commented May 2, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2025

Going to push as commit c514f13.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2025
@openjdk openjdk bot closed this May 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2025
@openjdk
Copy link

openjdk bot commented May 2, 2025

@wangweij Pushed as commit c514f13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8356051 branch May 2, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants