8354969: Add strdup function for ResourceArea

[toxaart]

Added a strdup() method, as requested by the bug reporter. The method is added to Arena, but also available in ResourceArea, as requested. A test for the method is provided.

Testing: tiers 1-4 on multiple platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354969: Add strdup function for ResourceArea (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer) Review applies to 0c57dee8

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24998/head:pull/24998
$ git checkout pull/24998

Update a local copy of the PR:
$ git checkout pull/24998
$ git pull https://git.openjdk.org/jdk.git pull/24998/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24998

View PR using the GUI difftool:
$ git pr show -t 24998

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24998.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toxaart This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354969: Add strdup function for ResourceArea

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

• e961b13: 8356165: System.in in jshell replace supplementary characters with ??
• f8d7f66: 8356998: Convert -Xlog:cds to -Xlog:aot (step 2)
• 7077535: 8356595: Convert -Xlog:cds to -Xlog:aot (step1)
• ... and 136 more: https://git.openjdk.org/jdk/compare/39a28ffe4e23274dba34317d8960bfb7e6d203ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @iklam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@toxaart The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (e65548d5)
• 04: Full - Incremental (fb64830a)
• 03: Full - Incremental (155fd3ed)
• 02: Full - Incremental (0c57dee8)
• 01: Full - Incremental (777756e1)
• 00: Full (2f8f78e7)

[dholmes-ora]

Do we have any immediate candidate uses for this? Whilst in the past Hotspot code had a number of utility API's, these days there is a tendency to delete any unused code. So this really needs to have an imminent usage (@iklam ?) .

Code change itself looks fine. Thanks

[iklam]

Do we have any immediate candidate uses for this? Whilst in the past Hotspot code had a number of utility API's, these days there is a tendency to delete any unused code. So this really needs to have an imminent usage (@iklam ?) .

Code change itself looks fine. Thanks

I did this and found a few places, but there could be more

find . -name \*pp | xargs grep -l strcpy | \
    xargs egrep -l '(RESOURCE.*char)|(resource_allocate_bytes)' | \
    xargs grep strcpy

jdk/src/hotspot/share/prims/jvmtiEnvBase.cpp

Lines 471 to 472 in 9a0e6f3

	char* prefix_copy = NEW_RESOURCE_ARRAY(char, strlen(prefix)+1);
	strcpy(prefix_copy, prefix);

jdk/src/hotspot/share/classfile/classLoader.cpp

Lines 1513 to 1514 in 9a0e6f3

	char* orig_copy = NEW_RESOURCE_ARRAY_IN_THREAD(thread, char, strlen(orig)+1);
	strcpy(orig_copy, orig);

jdk/src/hotspot/share/classfile/modules.cpp

Lines 642 to 643 in 9a0e6f3

	char* p = resource_allocate_bytes(strlen(prop_value) + 1);
	strcpy(p, prop_value);

[dholmes-ora]

Thanks @iklam ! So should we convert those places as part of this PR?

[iklam]

Thanks @iklam ! So should we convert those places as part of this PR?

I think we should do that. @toxaart could you see if there are other cases that can also be converted?

[toxaart]

@iklam I converted the cases you suggested and found a few more. Addressed in the latest commit.

[iklam]

LGTM. Please make sure you do sufficient testing before integrating. I would suggest running up to at least tier 4, as changes of this kind sometimes can touch obscure code paths.

[dholmes-ora]

Looks good! Thanks for the update.

One further, non-essential, suggestion.

[dholmes-ora]

Ship it!

[toxaart]

Thanks, let's
/integrate

[openjdk]

@toxaart
Your change (at version e65548d) is now ready to be sponsored by a Committer.

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 0db5511.
Since your change was applied there have been 140 commits pushed to the master branch:

• f8fc7ee: 8357052: java/io/File/GetXSpace.java prints wrong values in exception
• e961b13: 8356165: System.in in jshell replace supplementary characters with ??
• f8d7f66: 8356998: Convert -Xlog:cds to -Xlog:aot (step 2)
• ... and 137 more: https://git.openjdk.org/jdk/compare/39a28ffe4e23274dba34317d8960bfb7e6d203ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @toxaart Pushed as commit 0db5511.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.