Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252998: ModuleWrapper.gmk doesn't consult include path #250

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented Sep 18, 2020

A change made to ModuleWrapper.gmk as part of JDK-8244044 means that an included makefile is found in the current directory, so Make doesn't check the include dirs for overriding gmk files.

Recommend a minor, partial reversion of this changeset to ensure any override files are included instead.

Bug: https://bugs.openjdk.java.net/browse/JDK-8252998


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252998: ModuleWrapper.gmk doesn't consult include path

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/250/head:pull/250
$ git checkout pull/250

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@adamfarley The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252998: ModuleWrapper.gmk doesn't consult include path

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 289 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@jerboaa
Copy link
Contributor

jerboaa commented Sep 21, 2020

@adamfarley Please see #250 (comment) for getting this integrated. For non-committers it's /integrate and then /sponsor by somebody with commit rights.

@adamfarley
Copy link
Author

adamfarley commented Oct 2, 2020

Apologies for the delay.

@adamfarley
Copy link
Author

adamfarley commented Oct 2, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 2, 2020
@openjdk
Copy link

openjdk bot commented Oct 2, 2020

@adamfarley
Your change (at version e48dabc) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Oct 5, 2020

/sponsor

@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2020
@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@jerboaa @adamfarley Since your change was applied there have been 297 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 289ae79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@adamfarley
Copy link
Author

adamfarley commented Oct 5, 2020

Thanks @jerboaa :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants