Skip to content

8356075: Support Shenandoah GC in JVMCI #25001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

8356075: Support Shenandoah GC in JVMCI #25001

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
344955a
Graal Shenandoah support
rkennke Apr 2, 2025
956bbec
Revert "8321373: Build should use LC_ALL=C.UTF-8"
rkennke Apr 9, 2025
0bcdb7d
Support for Shenandoah card-table barriers in JVMCI
rkennke Apr 17, 2025
2f54728
Merge branch 'master' into graal-shenandoah-support
rkennke Apr 30, 2025
f54cb48
Revert unrelated changes
rkennke May 2, 2025
1543e8f
Revert unrelated changes
rkennke May 2, 2025
25a8a6f
Remove unnecessary stuff
rkennke May 2, 2025
6487a9f
Fix ordering of includes
rkennke May 2, 2025
c95313a
Initialize cardtable_start_address to nullptr
rkennke May 5, 2025
4434458
Align backslashes
rkennke May 5, 2025
41084f3
Simplify pre-barrier runtime entry
rkennke May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ void CompilerToVM::Data::initialize(JVMCI_TRAPS) {
cardtable_start_address = base;
cardtable_shift = CardTable::card_shift();
} else if (bs->is_a(BarrierSet::ShenandoahBarrierSet)) {
Copy link
Member

@dougxc dougxc May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is causing a failure in mach5 tier 1:

[2025-05-06T11:34:44,742Z] /workspace/open/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp:239:35: error: no member named 'ShenandoahBarrierSet' in 'BarrierSet'
[2025-05-06T11:34:44,742Z]   } else if (bs->is_a(BarrierSet::ShenandoahBarrierSet)) {
[2025-05-06T11:34:44,742Z]                       ~~~~~~~~~~~~^
[2025-05-06T11:34:45,729Z] 1 error generated.

I assume it's missing #if INCLUDE_SHENANDOAHGC.

https://bugs.openjdk.org/browse/JDK-8356265

cardtable_start_address = nullptr;
cardtable_shift = CardTable::card_shift();
} else {
// No card mark barriers
Expand Down