8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes #25002

lahodaj · 2025-05-02T11:37:40Z

Consider code like:

import java.lang.annotation.*;

public class PrintingTest<T extends CharSequence> extends @TA Object {
}

@Target(ElementType.TYPE_USE)
@interface TA {}

when using -Xprint to print this code, javac produces this:

public class PrintingTest<T> {

  public PrintingTest();
}

@java.lang.annotation.Target({TYPE_USE})
@interface TA {
}

Note the type variable is missing the bound, and the annotated supertype is missing. This PR proposes to change that to:

public class PrintingTest<T extends java.lang.CharSequence> extends java.lang.@TA Object {

  public PrintingTest();
}

@java.lang.annotation.Target({TYPE_USE})
@interface TA {
}

Please also review the CSR:
https://bugs.openjdk.org/browse/JDK-8356058
and the release note:
https://bugs.openjdk.org/browse/JDK-8356062

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8356058 to be approved

Issues

JDK-8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes (Bug - P4)
JDK-8356058: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes (CSR)

Reviewers

Vicente Romero (@vicente-romero-oracle - Reviewer) Review applies to a9f7be23
Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25002/head:pull/25002
$ git checkout pull/25002

Update a local copy of the PR:
$ git checkout pull/25002
$ git pull https://git.openjdk.org/jdk.git pull/25002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25002

View PR using the GUI difftool:
$ git pr show -t 25002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25002.diff

Using Webrev

Link to Webrev Comment

…nds and type annotations for Object supertypes

bridgekeeper · 2025-05-02T11:38:19Z

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-05-02T11:38:54Z

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes

Reviewed-by: darcy, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

45dfc2c: 8353642: Deprecate URL::getPermission method and networking permission classes for removal
8d7866e: 8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet
50dced8: 8356656: Drop unused DEVKIT_HOME from jib-profiles.js
... and 163 more: https://git.openjdk.org/jdk/compare/d29700cc80003d6baddb419f2974ab226478bacc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-05-02T11:39:32Z

@lahodaj The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-05-02T11:42:26Z

Webrevs

vicente-romero-oracle

lgtm

jddarcy · 2025-05-02T19:49:58Z

src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java

+            List<? extends TypeMirror> printableBounds =
+                    tpe.getBounds()
+                       .stream()
+                       .filter(type -> !isUnimportantObjectType(type))


Perhaps the changes would be easier to ready if the method as "isImportantObjectType()"?

Thanks, done under:
e78e88a

…rtantObjectType.

…uctors.

jddarcy · 2025-05-05T19:59:06Z

src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java

+            if (!e2.getKind().isClass()) {
+                return true;
+            }
+            return e2.getSuperclass().getKind() != TypeKind.NONE;


I think it would be helpful to include some textual description of the intended semantics here including

"Omit the bound is unannotated java.lang.Object."

Done:
9bb3677

lahodaj · 2025-05-13T04:43:13Z

/integrate

openjdk · 2025-05-13T04:44:08Z

Going to push as commit 24d77ad.
Since your change was applied there have been 173 commits pushed to the master branch:

4fc10a1: 8356087: Problematic KeyInfo check using key algorithm in P11SecretKeyFactory class
adebfa7: 8356700: RISC-V: Declare incompressible scope in fill_words / zero_memory assembler routines
303f410: 8355708: Two Float16 IR tests fail after JDK-8345125
... and 170 more: https://git.openjdk.org/jdk/compare/d29700cc80003d6baddb419f2974ab226478bacc...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-05-13T04:44:14Z

@lahodaj Pushed as commit 24d77ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

lahodaj added 3 commits May 2, 2025 08:54

8356057: PrintingProcessor (-Xprint) does not print type variable bou…

83207d7

…nds and type annotations for Object supertypes

Fixing type var bounds.

414c704

Adjusting test output.

a9f7be2

openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels May 2, 2025

openjdk bot added the compiler compiler-dev@openjdk.org label May 2, 2025

vicente-romero-oracle approved these changes May 2, 2025

View reviewed changes

jddarcy reviewed May 2, 2025

View reviewed changes

lahodaj added 2 commits May 5, 2025 16:57

Reflecting review feedback: using isImportantType instead of isUnimpo…

e78e88a

…rtantObjectType.

Enhancing the test with printing type variables on methods and constr…

308d9f4

…uctors.

jddarcy reviewed May 5, 2025

View reviewed changes

lahodaj added 2 commits May 12, 2025 13:14

Reflecting review comment: adding description.

9bb3677

Adding test for recursive bounds.

3f50dbb

jddarcy approved these changes May 12, 2025

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 12, 2025

openjdk bot added the integrated Pull request has been integrated label May 13, 2025

openjdk bot closed this May 13, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes #25002

8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes #25002

Uh oh!

lahodaj commented May 2, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented May 2, 2025

Uh oh!

openjdk bot commented May 2, 2025 •

edited

Loading

Uh oh!

openjdk bot commented May 2, 2025

Uh oh!

mlbridge bot commented May 2, 2025 •

edited

Loading

Uh oh!

vicente-romero-oracle left a comment

Uh oh!

jddarcy May 2, 2025

Uh oh!

lahodaj May 5, 2025

Uh oh!

jddarcy May 5, 2025

Uh oh!

lahodaj May 12, 2025

Uh oh!

lahodaj commented May 13, 2025

Uh oh!

openjdk bot commented May 13, 2025

Uh oh!

openjdk bot commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes #25002

8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes #25002

Uh oh!

Conversation

lahodaj commented May 2, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 2, 2025

Uh oh!

openjdk bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented May 2, 2025

Uh oh!

mlbridge bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

vicente-romero-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

jddarcy May 2, 2025

Choose a reason for hiding this comment

Uh oh!

lahodaj May 5, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy May 5, 2025

Choose a reason for hiding this comment

Uh oh!

lahodaj May 12, 2025

Choose a reason for hiding this comment

Uh oh!

lahodaj commented May 13, 2025

Uh oh!

openjdk bot commented May 13, 2025

Uh oh!

openjdk bot commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

lahodaj commented May 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented May 2, 2025 •

edited

Loading

mlbridge bot commented May 2, 2025 •

edited

Loading