Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261500: Shenandoah: reconsider region live data memory ordering #2503

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Feb 10, 2021

Current Shenandoah region live data tracking uses default CAS updates to achieve atomicity of updates. Hotspot's default for atomic operations is memory_order_conservative, which emits two-way memory fences around the CASes at least on AArch64 and PPC64.

This seems to be excessive for live data tracking, and "relaxed" could be used instead. The only serious user of that data is collection set chooser, which runs at safepoint and so everything should be quiescent when that happens.

Additional testing:

  • Linux x86_64 hotspot_gc_shenandoah
  • Linux AArch64 hotspot_gc_shenandoah
  • Linux AArch64 tier1 with Shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261500: Shenandoah: reconsider region live data memory ordering

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2503/head:pull/2503
$ git checkout pull/2503

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 10, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 10, 2021

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@shipilev shipilev marked this pull request as ready for review Feb 10, 2021
@openjdk openjdk bot added the rfr label Feb 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 10, 2021

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented Feb 10, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261500: Shenandoah: reconsider region live data memory ordering

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 40754f1: 4841153: java.awt.geom.Rectangle2D.add(double,double) documented incorrectly
  • 4caeb39: 8260380: Upgrade to LittleCMS 2.12
  • a772639: 8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo
  • 52fc01b: 8261268: LOAD_INSTANCE placeholders unneeded for parallelCapable class loaders
  • a3d6e37: 8261302: NMT: Improve malloc site table hashing
  • ad54d8d: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 752f92b: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified
  • 3af334a: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified
  • 4619f37: 8261472: BasicConstraintsExtension::toString shows "PathLen:2147483647" if there is no pathLenConstraint
  • 699a3cd: 8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Feb 15, 2021

/integrate

@openjdk openjdk bot closed this Feb 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2021

@shipilev Since your change was applied there have been 80 commits pushed to the master branch:

  • df0897e: 8261504: Shenandoah: reconsider ShenandoahJavaThreadsIterator::claim memory ordering
  • 745c0b9: 8261493: Shenandoah: reconsider bitmap access memory ordering
  • 4642730: 8261496: Shenandoah: reconsider pacing updates memory ordering
  • 7c93159: 8261503: Shenandoah: reconsider verifier memory ordering
  • d9744f6: 8261608: Move common CDS archive building code to archiveBuilder.cpp
  • 235da6a: 8261672: Reduce inclusion of classLoaderData.hpp
  • 95d7312: 8261585: Restore HandleArea used in Deoptimization::uncommon_trap
  • 849390a: 8260401: StackOverflowError on open WindowsPreferences
  • 735757f: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big
  • e29c560: 8247514: Improve clhsdb 'findpc' ability to determine what an address points to by improving PointerFinder and PointerLocation classes
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

Your commit was automatically rebased without conflicts.

Pushed as commit c6eedda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the shipilev:JDK-8261500-shenandoah-livedata-memord branch Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants