8356182: Build fails on aarch64 without ZGC

[snake66]

jvmciCodeInstaller_aarch64.cpp references symbols defined by the ZGC unconditionally, causing the build to fail when ZGC is not included.

This work is sponsored by The FreeBSD FOundation

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356182: Build fails on aarch64 without ZGC (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25039/head:pull/25039
$ git checkout pull/25039

Update a local copy of the PR:
$ git checkout pull/25039
$ git pull https://git.openjdk.org/jdk.git pull/25039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25039

View PR using the GUI difftool:
$ git pr show -t 25039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25039.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snake66! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@snake66 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356182: Build fails on aarch64 without ZGC

This work was sponsored by The FreeBSD Foundation

Reviewed-by: stefank, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@snake66 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7b492d8e)

[stefank]

Looks good to me. Needs another review from a compiler dev as well.

[snake66]

@stefank Thank you!

[chhagedorn]

Looks good to me, too.

[snake66]

@chhagedorn Thank you!

[snake66]

/summary This work was sponsored by The FreeBSD Foundation

[openjdk]

@snake66 Setting summary to This work was sponsored by The FreeBSD Foundation

[snake66]

/integrate

[openjdk]

@snake66
Your change (at version 7b492d8) is now ready to be sponsored by a Committer.

[snake66]

If anybody would be willing to sponsor this trivial change, it'd be much appreciated.

Thanks in advance!

[chhagedorn]

/sponsor

[openjdk]

Going to push as commit 8c4f2ff.
Since your change was applied there have been 16 commits pushed to the master branch:

• def907a: 8354520: IGV: dump contextual information
• 9f8fbf2: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects
• e09d2e2: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI
• ... and 13 more: https://git.openjdk.org/jdk/compare/1501a5e41e59162a374cf5b8cfc37faced48a6ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @snake66 Pushed as commit 8c4f2ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[snake66]

@chhagedorn Thank you! :)