Skip to content

8356187: TestJcmd.java may incorrectly parse podman version#25041

Closed
Domest0s wants to merge 2 commits intoopenjdk:masterfrom
Domest0s:8356187_TestJcmd_may_incorrectly_parse_podman
Closed

8356187: TestJcmd.java may incorrectly parse podman version#25041
Domest0s wants to merge 2 commits intoopenjdk:masterfrom
Domest0s:8356187_TestJcmd_may_incorrectly_parse_podman

Conversation

@Domest0s
Copy link
Contributor

@Domest0s Domest0s commented May 5, 2025

fixing an issue with TestJcmd.java test not able to parse podman version string of kind "podman version 4.9.4-rhel".

Tested locally - run test with mocked podman version string.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356187: TestJcmd.java may incorrectly parse podman version (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25041/head:pull/25041
$ git checkout pull/25041

Update a local copy of the PR:
$ git checkout pull/25041
$ git pull https://git.openjdk.org/jdk.git pull/25041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25041

View PR using the GUI difftool:
$ git pr show -t 25041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25041.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2025

👋 Welcome back Domest0s! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 5, 2025

@Domest0s This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356187: TestJcmd.java may incorrectly parse podman version

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 5, 2025

@Domest0s The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 5, 2025
@Domest0s Domest0s changed the title TestJcmd.java may incorrectly parse podman version 8356187 May 5, 2025
@openjdk openjdk bot changed the title 8356187 8356187: TestJcmd.java may incorrectly parse podman version May 5, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2025
@mlbridge
Copy link

mlbridge bot commented May 5, 2025

Webrevs

@myankelev
Copy link
Member

Nitpick: Copyright :)

@Domest0s
Copy link
Contributor Author

Domest0s commented May 6, 2025

Nitpick: Copyright :)

Ah, true. Will fix the year shortly. Thank you

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2025
@Domest0s
Copy link
Contributor Author

Domest0s commented May 7, 2025

@myankelev @jerboaa thank you for reviewing.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@Domest0s
Your change (at version 345fb84) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented May 7, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented May 7, 2025

Going to push as commit 328715d.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2025
@openjdk openjdk bot closed this May 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@jerboaa @Domest0s Pushed as commit 328715d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants