8356187: TestJcmd.java may incorrectly parse podman version#25041
8356187: TestJcmd.java may incorrectly parse podman version#25041Domest0s wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back Domest0s! A progress list of the required criteria for merging this PR into |
|
@Domest0s This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 47 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
Nitpick: Copyright :) |
Ah, true. Will fix the year shortly. Thank you |
jerboaa
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing it.
|
@myankelev @jerboaa thank you for reviewing. /integrate |
|
/sponsor |
|
Going to push as commit 328715d.
Your commit was automatically rebased without conflicts. |
fixing an issue with TestJcmd.java test not able to parse podman version string of kind "podman version 4.9.4-rhel".
Tested locally - run test with mocked podman version string.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25041/head:pull/25041$ git checkout pull/25041Update a local copy of the PR:
$ git checkout pull/25041$ git pull https://git.openjdk.org/jdk.git pull/25041/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25041View PR using the GUI difftool:
$ git pr show -t 25041Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25041.diff
Using Webrev
Link to Webrev Comment