8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled

[lmesnik]

Test fails with OOME if CDS is disabled. It is not a regression, it just rarely executed in this mode.
The fix is just to slightly increase Metaspace.
Verified that test now pass with CDS disabled + Xcomp. (It fails with Xcomp only)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled (Bug - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25046/head:pull/25046
$ git checkout pull/25046

Update a local copy of the PR:
$ git checkout pull/25046
$ git pull https://git.openjdk.org/jdk.git pull/25046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25046

View PR using the GUI difftool:
$ git pr show -t 25046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25046.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 614ba9f: 8356075: Support Shenandoah GC in JVMCI
• ecfaf35: 8356083: ZGC: Duplicate ZTestEntry symbols in gtests
• 1eee15e: 8258229: Crash in nmethod::reloc_string_for
• ... and 16 more: https://git.openjdk.org/jdk/compare/6719b9214fb9c99da52e5d6c11f5d40b2aa73bd9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8c587182)

[lmesnik]

/cc hotspot-runtime

[openjdk]

@lmesnik
The hotspot-runtime label was successfully added.

[coleenp]

So this still passes with CDS on though? I shrunk this one with ad10493 to 10. There's another test that I increased MaxMetaspaceSize for valhalla but I can't find it right now.

[lmesnik]

yes, still pass, it takes 3 seconds instead of 2 on my laptop. But nont-CDS configuration worth to test.

[lmesnik]

/integrate

[openjdk]

Going to push as commit c8a30c2.
Since your change was applied there have been 59 commits pushed to the master branch:

• 90f0f1b: 8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java
• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ca5e0b1: 8282493: Add --with-jcov-modules convenience option
• ... and 56 more: https://git.openjdk.org/jdk/compare/6719b9214fb9c99da52e5d6c11f5d40b2aa73bd9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit c8a30c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.