Skip to content

8356208: Remove obsolete code in PSPrinterJob for plugin printing #25047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented May 5, 2025

Delete the obsolete classes PluginPrinter and EPSPrinter. They were only ever called by the Java Plugin printing for applets.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356208: Remove obsolete code in PSPrinterJob for plugin printing (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25047/head:pull/25047
$ git checkout pull/25047

Update a local copy of the PR:
$ git checkout pull/25047
$ git pull https://git.openjdk.org/jdk.git pull/25047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25047

View PR using the GUI difftool:
$ git pr show -t 25047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25047.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 5, 2025

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356208: Remove obsolete code in PSPrinterJob for plugin printing

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8356208 8356208: Remove obsolete code in PSPrinterJob for plugin printing. May 5, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2025
@openjdk
Copy link

openjdk bot commented May 5, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 5, 2025
@mlbridge
Copy link

mlbridge bot commented May 5, 2025

Webrevs

@prrace prrace changed the title 8356208: Remove obsolete code in PSPrinterJob for plugin printing. 8356208: Remove obsolete code in PSPrinterJob for plugin printing May 5, 2025
@openjdk openjdk bot changed the title 8356208: Remove obsolete code in PSPrinterJob for plugin printing 8356208: Remove obsolete code in PSPrinterJob for plugin printing. May 5, 2025
@prrace prrace changed the title 8356208: Remove obsolete code in PSPrinterJob for plugin printing. 8356208: Remove obsolete code in PSPrinterJob for plugin printing May 5, 2025
if (mDestType == RasterPrinterJob.FILE) {
try {
spoolFile = new File(mDestination);
output = new FileOutputStream(spoolFile);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output = new FileOutputStream(spoolFile);
output = new FileOutputStream(spoolFile);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-existing but I guess I can do it since I'm pushing another commit for the other stuff to delete.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2025
@prrace
Copy link
Contributor Author

prrace commented May 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2025

Going to push as commit 4e3ec3c.
Since your change was applied there have been 74 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2025
@openjdk openjdk bot closed this May 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@prrace Pushed as commit 4e3ec3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants