8356259: Lift basic -Xlog:jit* logging to "info" level

[shipilev]

We have unified logging for JIT activity: -Xlog:jit+compilation, -Xlog:jit+inlining, etc. These serve as convenient replacements for -XX:+PrintCompilation, -XX:+PrintInlining, etc. And these replacements are useful, because UL can be forwarded to file, their format can be adjusted, and they can be handled asynchronously.

However, all useful messages are on "debug" level, which is inconvenient and surprising. It is reasonable to expect some level of basic logging when supplying -Xlog:jit+compilation, e.g. "info" level. I believe we should lift at least some of the logging to "info" level for these.

Additional testing:

• Eyeballing -Xlog:jit* logs after the patch
• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356259: Lift basic -Xlog:jit* logging to "info" level (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25061/head:pull/25061
$ git checkout pull/25061

Update a local copy of the PR:
$ git checkout pull/25061
$ git pull https://git.openjdk.org/jdk.git pull/25061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25061

View PR using the GUI difftool:
$ git pr show -t 25061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25061.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356259: Lift basic -Xlog:jit* logging to "info" level

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 9a23f72: 8316682: serviceability/jvmti/vthread/SelfSuspendDisablerTest timed out
• bed5114: 8356209: Problemlist failed gtests on static-jdk
• e2df9cd: 8356226: JCov Grabber server didn't respond
• ... and 39 more: https://git.openjdk.org/jdk/compare/8511220f9dd1428f9793ead43c20ed197881ab36...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2b8c9576)
• 00: Full (2e1b9e64)

[vnkozlov]

PrintInlining and PrintIntrinsics are diagnostic flags (while PrintCompilation is product).
So mapping UL Info to product flag and Debug to diagnostic seems valid.

Based on this, I agree with changes to CT::print_ul() but not others.

[shipilev]

PrintInlining and PrintIntrinsics are diagnostic flags (while PrintCompilation is product). So mapping UL Info to product flag and Debug to diagnostic seems valid. Based on this, I agree with changes to CT::print_ul() but not others.

I am mostly interested in PrintCompilation myself, so that would be an acceptable compromise.

However, I do believe that PrintInlining along with TraceTypeProfile are very useful to figure out performance anomalies in the field. Those really should not be diagnostic, and UL should really be "info" for them :) But we can have that discussion at some point later.

[vnkozlov]

Trivial.

[shipilev]

OK, thanks!

[shipilev]

/integrate

[openjdk]

Going to push as commit 5089583.
Since your change was applied there have been 51 commits pushed to the master branch:

• 21f01e0: 8356269: Fix broken web-links after JDK-8295470
• 910d77d: 8354260: Launcher help text is wrong for -Xms
• 4458719: 8355249: Remove the use of WMIC from the entire source code
• ... and 48 more: https://git.openjdk.org/jdk/compare/8511220f9dd1428f9793ead43c20ed197881ab36...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 5089583.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.