8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer

[mychris]

On memory constrained devices, the test might get killed by the linux kernel OOM Killer.

Executing the test with the JTreg test harness makes the test fail and get killed by the OOM Killer.
Executing the test manually, by using the JTreg provided "rerun" command line, the test succeeds.
This happened on a Raspberry PI 2, which has only 1G of memory available.

I added an "os.maxMemory" requirement, so the test gets skipped.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer

Reviewers

• Stefan Johansson (@kstefanj - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2507/head:pull/2507
$ git checkout pull/2507

[bridgekeeper]

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mychris The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (54e9af5)

[kstefanj]

Hi Christoph,

This looks good. The test is setting a 1GB max heap so it seems reasonable to require the system to have at least that.

Another thing to look at when tests are getting killed by the OOM killer is the number of concurrent test jobs. For a system with 1GB of memory that should be 1, so in your case you can't go lower. To be certain you only run one test at a time you could run configure with --with-test-jobs=1 , but according to doc/testing.md this should be the default for your system:

The test concurrency (`-concurrency`).

Defaults to TEST_JOBS (if set by `--with-test-jobs=`), otherwise it defaults to
JOBS, except for Hotspot, where the default is *number of CPU cores/2*,
but never more than *memory size in GB/2*.

The reason that the rerun succeeds is most likely because then you don't have the JTREG process running along side the test and consuming resources.

[openjdk]

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer

Reviewed-by: sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 3210095: 8261079: Fix support for @hidden in classes and interfaces
• 9c0ec8d: 8260941: Remove the conc_scan parameter for CardTable
• da9895a: 8261499: Simplify HTML for javadoc links
• 0779add: 8255059: Regressions >5% in all Javadoc benchmarks in 16-b19
• 6a84ec6: 8260044: Parallel GC: Concurrent allocation after heap expansion may cause unnecessary full gc
• 92ff891: 8261593: Do not use NULL pointer as write buffer parameter in jfrEmergencyDump.cpp write_repository_files
• 60a2072: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr"
• bf47a47: 8261282: Lazy initialization of built-in ICC_Profile/ColorSpace classes is too lazy
• f4cfd75: 8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments
• 75c8489: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/a3d6e37153d09b3198c983bd7b689dca570386dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kstefanj, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mychris]

Hi Stefan,

thanks for the review. I am aware of the concurrency feature of the JTreg runner and am always using a concurrency of 1 on embedded devices. Even if they are more powerful, since it makes the test execution less reliable.

I found some more tests with the same problem, but will file a single bug and fix all in one go, as soon as I have time for that.

/integrate

[openjdk]

@mychris
Your change (at version 54e9af5) is now ready to be sponsored by a Committer.

[kstefanj]

I'll wait for a second reviewer before sponsoring this, just in case anyone has a different view on how to handle this.

[tschatzl]

Lgtm.

[kstefanj]

/sponsor

[openjdk]

@kstefanj @mychris Since your change was applied there have been 30 commits pushed to the master branch:

• 3210095: 8261079: Fix support for @hidden in classes and interfaces
• 9c0ec8d: 8260941: Remove the conc_scan parameter for CardTable
• da9895a: 8261499: Simplify HTML for javadoc links
• 0779add: 8255059: Regressions >5% in all Javadoc benchmarks in 16-b19
• 6a84ec6: 8260044: Parallel GC: Concurrent allocation after heap expansion may cause unnecessary full gc
• 92ff891: 8261593: Do not use NULL pointer as write buffer parameter in jfrEmergencyDump.cpp write_repository_files
• 60a2072: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr"
• bf47a47: 8261282: Lazy initialization of built-in ICC_Profile/ColorSpace classes is too lazy
• f4cfd75: 8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments
• 75c8489: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/a3d6e37153d09b3198c983bd7b689dca570386dc...master

Your commit was automatically rebased without conflicts.

Pushed as commit ebaa58d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.