8356318: Unexpected VerifyError in AOT training run

[iklam]

This PR fixes a bug introduced by JDK-8348426 : when running with -XX:AOTMode=record, we incorrectly reject some valid classes that need to be verified with the old verifier.

This bug does not affect JDK 24.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356318: Unexpected VerifyError in AOT training run (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25074/head:pull/25074
$ git checkout pull/25074

Update a local copy of the PR:
$ git checkout pull/25074
$ git pull https://git.openjdk.org/jdk.git pull/25074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25074

View PR using the GUI difftool:
$ git pr show -t 25074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25074.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356318: Unexpected VerifyError in AOT training run

Reviewed-by: shade, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ca5e0b1: 8282493: Add --with-jcov-modules convenience option
• a72f750: 8356379: Need a proper way to test existence of binary from configure
• ... and 43 more: https://git.openjdk.org/jdk/compare/64b58f6a54c1197002527bdb6ba7b48283dc634e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (674e1301)

[shipilev]

Looks fine, thanks!

[vnkozlov]

Good.

[iklam]

Thanks @shipilev @vnkozlov for the review
/integrate

[openjdk]

Going to push as commit 40f696d.
Since your change was applied there have been 49 commits pushed to the master branch:

• da5dc52: 8356025: Provide a PrintVMInfoAtExit diagnostic switch
• c8a30c2: 8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled
• 90f0f1b: 8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java
• ... and 46 more: https://git.openjdk.org/jdk/compare/64b58f6a54c1197002527bdb6ba7b48283dc634e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 40f696d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.