8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java

[gergo-]

Remove special cases in nmethod::is_deopt_entry and nmethod::is_deopt_mh_entry. Graal used to generate a different code pattern from C2 for deopt handlers. This was changed in oracle/graal@099f57b to align Graal's code generation with C2. The special cases are no longer needed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java (Bug - P3)

Reviewers

• Doug Simon (@dougxc - Reviewer)
• Yudi Zheng (@mur47x111 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25088/head:pull/25088
$ git checkout pull/25088

Update a local copy of the PR:
$ git checkout pull/25088
$ git pull https://git.openjdk.org/jdk.git pull/25088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25088

View PR using the GUI difftool:
$ git pr show -t 25088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25088.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gbarany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gergo- This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java

Reviewed-by: dnsimon, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ca5e0b1: 8282493: Add --with-jcov-modules convenience option
• a72f750: 8356379: Need a proper way to test existence of binary from configure
• ... and 39 more: https://git.openjdk.org/jdk/compare/8c4f2ff21e21b158c333b3d36fcf323f68f4d187...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @mur47x111) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@gergo- The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[gergo-]

/label graal

[openjdk]

@gergo-
The graal label was successfully added.

[mlbridge]

Webrevs

• 00: Full (8028476c)

[dougxc]

LGTM

[mur47x111]

LGTM

[gergo-]

Thanks for your reviews!

/integrate

[openjdk]

@gergo-
Your change (at version 8028476) is now ready to be sponsored by a Committer.

[mur47x111]

/sponsor

[openjdk]

Going to push as commit 90f0f1b.
Since your change was applied there have been 42 commits pushed to the master branch:

• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ca5e0b1: 8282493: Add --with-jcov-modules convenience option
• a72f750: 8356379: Need a proper way to test existence of binary from configure
• ... and 39 more: https://git.openjdk.org/jdk/compare/8c4f2ff21e21b158c333b3d36fcf323f68f4d187...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mur47x111 @gergo- Pushed as commit 90f0f1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.