Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented May 7, 2025

Simple clarification of the Console.charset() method description, making explicit how the charset is applied.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356221: Clarify Console.charset() method description (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25103/head:pull/25103
$ git checkout pull/25103

Update a local copy of the PR:
$ git checkout pull/25103
$ git pull https://git.openjdk.org/jdk.git pull/25103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25103

View PR using the GUI difftool:
$ git pr show -t 25103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25103.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356221: Clarify Console.charset() method description

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 7, 2025
@naotoj naotoj marked this pull request as ready for review May 7, 2025 17:04
@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2025
@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 7, 2025
@naotoj
Copy link
Member Author

naotoj commented May 8, 2025

Thanks for the review, Brian
/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2025

Going to push as commit e4ecda2.
Since your change was applied there have been 54 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2025
@openjdk openjdk bot closed this May 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@naotoj Pushed as commit e4ecda2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants