8356455: ZGC: Replace ZIntrusiveRBTree with IntrusiveRBTree

[xmas92]

JDK-8350441 was implemented before IntrusiveRBTree was introduced, and as such implemented its own intrusive red-black tree. Now that a shared data structure implementation is available, use that instead.

The switch is straight forward, and the O(1) left and right most node lookup which ZIntrusiveRBTree implements that IntrusiveRBTree does not is trivial to implement on top of the tree.

Initial performance evaluation shows no difference between the two implementations. And the functional testing passes.

Tested Oracle Supported platforms, Oracle tier1-8 ZGC testing tasks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356455: ZGC: Replace ZIntrusiveRBTree with IntrusiveRBTree (Enhancement - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer) Review applies to 3c3e22bf
• Joel Sikström (@jsikstro - Committer) Review applies to 4bc5cf09
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25112/head:pull/25112
$ git checkout pull/25112

Update a local copy of the PR:
$ git checkout pull/25112
$ git pull https://git.openjdk.org/jdk.git pull/25112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25112

View PR using the GUI difftool:
$ git pr show -t 25112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25112.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356455: ZGC: Replace ZIntrusiveRBTree with IntrusiveRBTree

Reviewed-by: stefank, eosterlund, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 1a97eb4: 8355515: Clarify the purpose of forcePass() and forceFail() methods
• ab985a7: 8341544: Restore fence() in Mutex
• 0db5511: 8354969: Add strdup function for ResourceArea
• ... and 1 more: https://git.openjdk.org/jdk/compare/e961b13cd68bc352b86af17c7e53df8537519beb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (a14736db)
• 02: Full - Incremental (0f406adf)
• 01: Full - Incremental (3c3e22bf)
• 00: Full (4bc5cf09)

[fisk]

Looks good.

[xmas92]

@stefank had some comments about having to much logic inlined. So abstracted the extra tree logic into its own inner class. Currently re-running tests.

[stefank]

Thanks for doing this cleanup. I have a few nits below.

[xmas92]

Thanks for the reviews
/integrate

[openjdk]

Going to push as commit 50e873f.
Since your change was applied there have been 13 commits pushed to the master branch:

• 74fc4e4: 8357179: Deprecate VFORK launch mechanism from Process implementation (linux)
• cedd1a5: 8357250: assert(shift >= 0 && shift < 4) failed: unexpected compressd klass shift!
• 972f2eb: 8351412: Add AVX-512 intrinsics for ML-KEM
• ... and 10 more: https://git.openjdk.org/jdk/compare/e961b13cd68bc352b86af17c7e53df8537519beb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 50e873f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.