Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261522: [PPC64] AES intrinsics write beyond the destination array #2514

Closed
wants to merge 3 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Feb 10, 2021

I'd like to replace the read-modify-write implementation from aescrypt_encryptBlock / aescrypt_decryptBlock stubs. It can cause severe problems (see bug description).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261522: [PPC64] AES intrinsics write beyond the destination array

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2514/head:pull/2514
$ git checkout pull/2514

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 10, 2021

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 10, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Feb 11, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 11, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2021

Webrevs

@jrziviani
Copy link
Contributor

jrziviani commented Feb 13, 2021

Tested on P8, P9, and P10. With this patch I don't reproduce the problem. (tested LE only)

Copy link
Contributor

@jrziviani jrziviani left a comment

Very good. +1

Copy link
Contributor

@jrziviani jrziviani left a comment

+1

Copy link
Contributor

@RealLucy RealLucy left a comment

Hi Martin,
the changes look good to me. Thanks for tracking that down and fixing it. I know that wasn't trivial.

One minor thing - it made me believe for a second I had missed something: in line 2631, the reference should be to vRet, not vsRet. Same is true further down in decryptBlock.

Lutz

@openjdk
Copy link

openjdk bot commented Feb 16, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261522: [PPC64] AES intrinsics write beyond the destination array

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • 16bd7d3: 8261336: IGV: enhance default filters
  • 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
  • 3cbd16d: 8259668: Make SubTasksDone use-once
  • 219b115: 8261422: Adjust problematic String.format calls in jdk/internal/util/Preconditions.java outOfBoundsMessage
  • cdc874d: 8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0
  • e2d52ae: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • 6badd22: 8261351: Create implementation for NSAccessibilityRadioButton protocol
  • 849f4c0: 8260291: The case instruction is not visible in dark mode
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/4caeb39f01b13b5472d8dacb268262fd418fd0c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Feb 16, 2021

Thanks a lot for the reviews!
I've fixed the typo in the comments as suggested by Lutz.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Feb 17, 2021

/integrate

@openjdk openjdk bot closed this Feb 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@TheRealMDoerr Since your change was applied there have been 82 commits pushed to the master branch:

  • 03b586b: 8261750: Remove internal class sun.net.www.MimeLauncher
  • 8418285: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
  • a930870: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
  • b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
  • d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
  • fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
  • d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
  • 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
  • e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
  • 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/4caeb39f01b13b5472d8dacb268262fd418fd0c4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 05d5955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8261522_PPC64_AES branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants