8356642: RISC-V: enable hotspot/jtreg/compiler/vectorapi/VectorFusedMultiplyAddSubTest.java

[Hamlin-Li]

Hi,
Can you help to review this patch?

API comibnation like av.lanewise(VectorOperators.FMA, bv.neg(), cv, mask).intoArray(fr, i); should be able to be optimized to some special instruct rather than a bunch of instructs.

We can not verify IR node (via beforeMatchingNameRegex) in PrintIdeal phase, as it does not mean that the special instruct are generated in FINAL CODE phase, it could be a combination of multiple different instruct.

As riscv use different instruct names, so I create new ones in IRNode.java.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356642: RISC-V: enable hotspot/jtreg/compiler/vectorapi/VectorFusedMultiplyAddSubTest.java (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Feilong Jiang (@feilongjiang - Committer)
• Manuel Hässig (@mhaessig - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25145/head:pull/25145
$ git checkout pull/25145

Update a local copy of the PR:
$ git checkout pull/25145
$ git pull https://git.openjdk.org/jdk.git pull/25145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25145

View PR using the GUI difftool:
$ git pr show -t 25145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25145.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356642: RISC-V: enable hotspot/jtreg/compiler/vectorapi/VectorFusedMultiplyAddSubTest.java

Reviewed-by: fyang, fjiang, mhaessig

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• ab8c808: 8356752: Log mouse enter and exit events for debugging
• 2b32541: 8354767: Test crashed: assert(increase < max_live_nodes_increase_per_iteration) failed: excessive live node increase in single iteration of IGVN: 4470 (should be at most 4000)
• 0258d99: 8347515: C2: assert(!success || (C->macro_count() == (old_macro_count - 1))) failed: elimination must have deleted one node from macro list
• ... and 69 more: https://git.openjdk.org/jdk/compare/ca5e0b1848054848fb5e39eebac06f2011cceb2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RealFYang]

Looks fine. You need to fix the jcheck error.

[feilongjiang]

Looks good!

[Hamlin-Li]

Looks fine. You need to fix the jcheck error.

Thanks! fixed.

[Hamlin-Li]

Looks good!

Thank you!

[mlbridge]

Webrevs

• 00: Full (35215f87)

[mhaessig]

The changes also look good to me. I kicked off testing and will come back to you once the results are in.

[mhaessig]

The tests passed.

[Hamlin-Li]

The tests passed.

Thank you for tesing!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit 8545e13.
Since your change was applied there have been 72 commits pushed to the master branch:

• ab8c808: 8356752: Log mouse enter and exit events for debugging
• 2b32541: 8354767: Test crashed: assert(increase < max_live_nodes_increase_per_iteration) failed: excessive live node increase in single iteration of IGVN: 4470 (should be at most 4000)
• 0258d99: 8347515: C2: assert(!success || (C->macro_count() == (old_macro_count - 1))) failed: elimination must have deleted one node from macro list
• ... and 69 more: https://git.openjdk.org/jdk/compare/ca5e0b1848054848fb5e39eebac06f2011cceb2e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 8545e13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.