-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8356644: Update encoding declaration to UTF-8 #25148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@magicus The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
dfuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to net-properties.html LGTM
| <head> | ||
| <title>README - CodePointIM</title> | ||
| <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> | ||
| <meta http-equiv="content-type" content="text/html; charset=utf-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is equivalent to simple <meta charset="utf-8"/> which is widely used in java.desktop's docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable, yes. However, I'd like to keep this change to the absolute minimum. Feel free to open a separate issue for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable, yes. However, I'd like to keep this change to the absolute minimum. Feel free to open a separate issue for fixing this.
|
/integrate |
|
Going to push as commit dd25159.
Your commit was automatically rebased without conflicts. |
A handful of html and xml files in the JDK source tree claims to have encodings like
ISO-8859-1, when they are in fact pure US-ASCII files.While perhaps technically correct, this is misleading, and goes contrary to the efforts of turning the source code into UTF-8 proper.
I chose between marking them as "ASCII" and "UTF-8", but chose the latter, since otherwise if they ever were to be updated with a non-ASCII character, the value would have been unspecified, and after JDK-8301971, all files in the JDK repository will be interpreted as UTF-8.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25148/head:pull/25148$ git checkout pull/25148Update a local copy of the PR:
$ git checkout pull/25148$ git pull https://git.openjdk.org/jdk.git pull/25148/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25148View PR using the GUI difftool:
$ git pr show -t 25148Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25148.diff
Using Webrev
Link to Webrev Comment