8351415: (fs) Path::toAbsolutePath should specify if an absolute path has a root component

[bplb]

Add a sentence to the specification of Path::toAbsolutePath indicating that the root component of the absolute path derived from a Path associated with the default provider is non-null.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8356804 to be approved

Issues

• JDK-8351415: (fs) Path::toAbsolutePath should specify if an absolute path has a root component (Bug - P4)
• JDK-8356804: (fs) Path::toAbsolutePath should specify if an absolute path has a root component (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25161/head:pull/25161
$ git checkout pull/25161

Update a local copy of the PR:
$ git checkout pull/25161
$ git pull https://git.openjdk.org/jdk.git pull/25161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25161

View PR using the GUI difftool:
$ git pr show -t 25161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25161.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351415: (fs) Path::toAbsolutePath should specify if an absolute path has a root component

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 0f5c608: 8356695: java/lang/StringBuilder/HugeCapacity.java failing with OOME
• 45dfc2c: 8353642: Deprecate URL::getPermission method and networking permission classes for removal
• 8d7866e: 8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet
• ... and 47 more: https://git.openjdk.org/jdk/compare/4379e2d26bd445d3f303a5937d1e335885be9216...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (484dc1aa)

[AlanBateman]

/csr

[openjdk]

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8351415 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[AlanBateman]

I think it is okay.

[bplb]

/csr

Created.

[bplb]

/integrate

[openjdk]

Going to push as commit 0318e49.
Since your change was applied there have been 75 commits pushed to the master branch:

• b8c69df: 8356551: Javac rejects receiver parameter in constructor of local class in early construction context
• 64a858c: 8355992: Add unsignedMultiplyExact and *powExact methods to Math and StrictMath
• 066477d: 8356080: Address post-integration comments for Stable Values
• ... and 72 more: https://git.openjdk.org/jdk/compare/4379e2d26bd445d3f303a5937d1e335885be9216...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 0318e49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.