8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet

[bplb]

Drop-in replacement in sun.nio.fs.UnixFileAttributes::permissions of HashSet with EnumSet for hopefully improved efficiency. All tests containing PosixFileAttributes passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25162/head:pull/25162
$ git checkout pull/25162

Update a local copy of the PR:
$ git checkout pull/25162
$ git pull https://git.openjdk.org/jdk.git pull/25162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25162

View PR using the GUI difftool:
$ git pr show -t 25162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25162.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet

Reviewed-by: liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• fa7c5a6: 8356664: [macos] AppContentTest fails after JDK-8352480
• 3b336a9: 8352675: Support Intel AVX10 converged vector ISA feature detection
• 0f2a6c2: 8356577: Migrate ClassFileVersionTest to be feature-agnostic
• ... and 26 more: https://git.openjdk.org/jdk/compare/4379e2d26bd445d3f303a5937d1e335885be9216...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (23223d41)

[liach]

Makes sense. This rejects usages of adding null or invalid objects, but this still abides to the specs, that the returned set can be modified and passed to create new attributes.

[AlanBateman]

I assume reading POSIX file permissions is going to be dominated by stat/equivalent, it might be that the JBS issue was more of a suggestion from someone reading the code?

In any case, it looks fine and I assume you'll run the jdk_nio tests.

[bplb]

In any case, it looks fine and I assume you'll run the jdk_nio tests.

Yes. I already ran those that mention PosixFileAttributes but I'll run all the jdk_nio tests for safety.

[bplb]

[...] I'll run all the jdk_nio tests for safety.

Passed on Linux and macOS.

[bplb]

/integrate

[openjdk]

Going to push as commit 8d7866e.
Since your change was applied there have been 47 commits pushed to the master branch:

• 50dced8: 8356656: Drop unused DEVKIT_HOME from jib-profiles.js
• e463895: 8356657: Use stable source-date for cmp-baseline jib profiles
• 8128f63: 8355692: Refactor stream indentation
• ... and 44 more: https://git.openjdk.org/jdk/compare/4379e2d26bd445d3f303a5937d1e335885be9216...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 8d7866e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.