JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments

[johnshajiang]

This is a simple cleanup for sun.security.ssl.SSLExtension.
The comments for the extension groups would use the RFC numbers and the protocol titles correspondingly.
It also removes a trailing space in extension token_binding, and move signature_algorithms and signature_algorithms_cert to RFC 8446 extension group.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments

Reviewers

• Bradford Wetmore (@bradfordwetmore - Reviewer)
• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2517/head:pull/2517
$ git checkout pull/2517

[bridgekeeper]

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@johnshajiang The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (f948498)
• 01: Full - Incremental (84f131c)
• 00: Full (7209b2b)

[XueleiFan]

What do you think if using "TLS 1.3 (RFC 8446)"?

[bradfordwetmore]

I agree with previous suggestion, but could you do throughout the file? Having something like either:

// extension defined in RFC 7301 (ALPN)
// extension defined in ALPN (RFC 7301)

throughout this file is encouraged and appreciated. Having the RFC #/short name of the document would be a lot more readable, rather than having to look up the RFC for a synopsis. e.g.

// extensions defined in RFC 8472
should be
// extensions defined in Token Binding Protocol Negotiation (RFC 8472)
or
// extensions defined in RFC 8472 (Token Binding Protocol Negotiation)

I noticed the previous comment for TLS1.3 wasn't fully addressed (line 314).

[bradfordwetmore]

Looks good, thanks.

[openjdk]

@johnshajiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261510: Use RFC numbers and protocol titles in sun.security.ssl.SSLExtension comments

Reviewed-by: wetmore, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 1740de2: 8261297: NMT: Final report should use scale 1
• c342323: 8261431: SA: Add comments about load address of executable
• 4a72cea: 8261509: Move per-thread StackWatermark from Thread to JavaThread class
• eef86a8: 8261029: Code heap page sizes not traced correctly using os::trace_page_sizes
• 0a89987: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
• 9fed604: 8261300: jpackage: rewrite while(0)/while(false) to proper blocks
• 8b6ab31: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets
• 5e1b809: 8261444: Remove unused fields in Lower
• a9c3680: 8261250: Dependencies: Remove unused dependency types
• 3ede231: 8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/40754f12f768ed1b32cbda187b0f43e9ee25c5c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[johnshajiang]

/integrate

[openjdk]

@johnshajiang Since your change was applied there have been 17 commits pushed to the master branch:

• 75c8489: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
• 1740de2: 8261297: NMT: Final report should use scale 1
• c342323: 8261431: SA: Add comments about load address of executable
• 4a72cea: 8261509: Move per-thread StackWatermark from Thread to JavaThread class
• eef86a8: 8261029: Code heap page sizes not traced correctly using os::trace_page_sizes
• 0a89987: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
• 9fed604: 8261300: jpackage: rewrite while(0)/while(false) to proper blocks
• 8b6ab31: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets
• 5e1b809: 8261444: Remove unused fields in Lower
• a9c3680: 8261250: Dependencies: Remove unused dependency types
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/40754f12f768ed1b32cbda187b0f43e9ee25c5c9...master

Your commit was automatically rebased without conflicts.

Pushed as commit f4cfd75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.