Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented May 12, 2025

These two subclass audits in ObjectInputStream and ObjectOutputStream were only used when security managers are present, which is no longer the case in releases 24 and newer. Thus, we can remove these two redundant ClassValue and the computation methods safely.

Testing: java/io/Serializable and ObjectInput, jdk tier 1-3 in progress


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356694: Removed unused subclass audits in ObjectInput/OutputStream (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25174/head:pull/25174
$ git checkout pull/25174

Update a local copy of the PR:
$ git checkout pull/25174
$ git pull https://git.openjdk.org/jdk.git pull/25174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25174

View PR using the GUI difftool:
$ git pr show -t 25174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25174.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356694: Removed unused subclass audits in ObjectInput/OutputStream

Reviewed-by: alanb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2025
@openjdk
Copy link

openjdk bot commented May 12, 2025

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 12, 2025
@mlbridge
Copy link

mlbridge bot commented May 12, 2025

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, looks like it was missed in the post JEP 486 cleanup.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2025
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@liach
Copy link
Member Author

liach commented May 12, 2025

Thanks for the reviews! JDK tier 1-3 all pass. Will wait for review from all time zones before integrating.

@liach
Copy link
Member Author

liach commented May 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2025

Going to push as commit a96424b.
Since your change was applied there have been 55 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2025
@openjdk openjdk bot closed this May 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@liach Pushed as commit a96424b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants