-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8356694: Removed unused subclass audits in ObjectInput/OutputStream #25174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, looks like it was missed in the post JEP 486 cleanup.
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
Thanks for the reviews! JDK tier 1-3 all pass. Will wait for review from all time zones before integrating. |
|
/integrate |
|
Going to push as commit a96424b.
Your commit was automatically rebased without conflicts. |
These two subclass audits in ObjectInputStream and ObjectOutputStream were only used when security managers are present, which is no longer the case in releases 24 and newer. Thus, we can remove these two redundant
ClassValueand the computation methods safely.Testing: java/io/Serializable and ObjectInput, jdk tier 1-3 in progress
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25174/head:pull/25174$ git checkout pull/25174Update a local copy of the PR:
$ git checkout pull/25174$ git pull https://git.openjdk.org/jdk.git pull/25174/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25174View PR using the GUI difftool:
$ git pr show -t 25174Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25174.diff
Using Webrev
Link to Webrev Comment