8356783: CompilerTask hot_method is redundant

[shipilev]

This gave me some grief when implementing JDK-8231269. From the initializations, it looks to me that CompilerTask::hot_method() is either method() or nullptr. In both cases, we do nothing special. So tracking hot_method is redundant, and can be purged. This improves performance a little, since it avoids extra handle-izing across compiler code, and of course it simplifies coding as well.

Additional testing:

• Linux x86_64 server fastdebug, compiler/
• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356783: CompilerTask hot_method is redundant (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Cesar Soares Lucas (@JohnTortugo - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25185/head:pull/25185
$ git checkout pull/25185

Update a local copy of the PR:
$ git checkout pull/25185
$ git pull https://git.openjdk.org/jdk.git pull/25185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25185

View PR using the GUI difftool:
$ git pr show -t 25185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25185.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356783: CompilerTask hot_method is redundant

Reviewed-by: kvn, cslucas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• 522c7b4: 8356175: Remove unnecessary Map.get from XWM.getInsets
• ad161a4: 8355360: -d option of jwebserver command should accept relative paths
• 526f543: 8353184: ZGC: Simplify and correct tlab_used() tracking
• ... and 71 more: https://git.openjdk.org/jdk/compare/ad07426fab3396caefd7c08d924e085c1f6f61ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (83b5398b)

[vnkozlov]

There was time when we compiled caller instead of method which triggers compilation (StackWalkCompPolicy). It was removed in JDK 13 JDK-8216360

[JohnTortugo]

LGTM

[shipilev]

Thanks! Testing is green here. I'll wait a bit more if anyone else wants to review, and then I'll integrate to continue with JDK-8231269.

[shipilev]

Here goes.

/integrate

[openjdk]

Going to push as commit 48d2acb.
Since your change was applied there have been 82 commits pushed to the master branch:

• de10644: 8356631: OopHandle replacement methods should not be called on empty handles
• 14d372b: 8356816: JFR: Move printing of metadata into separate class
• d930dc5: 8356275: TestCodeEntryAlignment fails with "Alignment must be <= CodeEntryAlignment"
• ... and 79 more: https://git.openjdk.org/jdk/compare/ad07426fab3396caefd7c08d924e085c1f6f61ba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 48d2acb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.