8356778: Compiler add event logging in case of failures #25188
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 102 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
changed the title
Webrevs
|
| @@ -646,6 +647,15 @@ void Compilation::notice_inlined_method(ciMethod* method) { | |||
|
|
|||
| void Compilation::bailout(const char* msg) { | |||
| assert(msg != nullptr, "bailout message must exist"); | |||
| // record the bailout for hserr envlog | |||
| if (msg != nullptr) { | |||
There was a problem hiding this comment.
How can it be nullptr? All callers pass some message.
There was a problem hiding this comment.
What if I create a new call like
char* myMsg = nullptr;
. . .
bailout(myMsg);
and, due to complicated logic, myMsg is not assigned a value in all cases? General topic: future-proof code.
There was a problem hiding this comment.
I could live with the check, but we get other problems when it is nullptr because nullptr is interpreted as no bailout!
bool bailed_out() const { return _bailout_msg != nullptr; }
There was a problem hiding this comment.
OK, with that knowledge and without the check, we crash when we try to log the null message. Otherwise, we crash or fail sometime later - or some strange things happen.
If we follow the "fail early" principle, the additional check should not be there. We could as well convert the assert into a guarantee to enforce a "planned" crash.
There was a problem hiding this comment.
okay I will remove the additional check , I think I saw the assert and thought , let's better do a check here to be on the safe side.
| @@ -646,6 +647,15 @@ void Compilation::notice_inlined_method(ciMethod* method) { | |||
|
|
|||
| void Compilation::bailout(const char* msg) { | |||
| assert(msg != nullptr, "bailout message must exist"); | |||
| // record the bailout for hserr envlog | |||
| if (msg != nullptr) { | |||
There was a problem hiding this comment.
What if I create a new call like
char* myMsg = nullptr;
. . .
bailout(myMsg);
and, due to complicated logic, myMsg is not assigned a value in all cases? General topic: future-proof code.
|
/integrate |
|
Going to push as commit 6c42856.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
We should add event logging to some related hotspot methods. While testing this functionality it turned out that sometimes the CompileTask pointer is 0, so this needs to be check to avoid crashes.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25188/head:pull/25188$ git checkout pull/25188Update a local copy of the PR:
$ git checkout pull/25188$ git pull https://git.openjdk.org/jdk.git pull/25188/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25188View PR using the GUI difftool:
$ git pr show -t 25188Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25188.diff
Using Webrev
Link to Webrev Comment