Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261482: Adjust jmap histo command to accept noparallel option to inspect heap serially #2519

Closed
wants to merge 1 commit into from

Conversation

@linzang
Copy link
Contributor

@linzang linzang commented Feb 11, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ The change requires a CSR request to be approved.

Issue

  • JDK-8261482: Adjust jmap histo command to accept noparallel option to inspect heap serially

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2519/head:pull/2519
$ git checkout pull/2519

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2021

👋 Welcome back lzang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@linzang The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@linzang
Copy link
Contributor Author

@linzang linzang commented Feb 11, 2021

/csr needed

@openjdk openjdk bot added the csr label Feb 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@linzang this pull request will not be integrated until the CSR request JDK-8261543 for issue JDK-8261482 has been approved.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2021

Webrevs

@linzang
Copy link
Contributor Author

@linzang linzang commented Feb 11, 2021

Dear All,
Stories and discussions related with this PR could be found at #2379 and #2261. Just FYI.
BRs,
Lin

@linzang linzang changed the title 8261482: Adjust jmap -histo to accept noparallel option to inspect heap serially 8261482: Adjust jmap histo command to accept noparallel option to inspect heap serially Feb 11, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Feb 16, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs label Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@AlanBateman
The core-libs label was successfully removed.

@linzang
Copy link
Contributor Author

@linzang linzang commented Feb 17, 2021

From the discussion of #2379, it is prefered to keep "parallel=n" option.
so close this PR.

@linzang linzang closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants