Skip to content

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented May 13, 2025

openssl from macOS will ignore faketime and as result expired certificates will not be generated correctly. By default we should use these tools from Homebrew.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356819: [macos] MacSign should use "openssl" and "faketime" from Homebrew by default (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25196/head:pull/25196
$ git checkout pull/25196

Update a local copy of the PR:
$ git checkout pull/25196
$ git pull https://git.openjdk.org/jdk.git pull/25196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25196

View PR using the GUI difftool:
$ git pr show -t 25196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25196.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2025

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2025

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356819: [macos] MacSign should use "openssl" and "faketime" from Homebrew by default

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 303f410: 8355708: Two Float16 IR tests fail after JDK-8345125
  • c23469d: 8355340: GenShen: Remove unneeded log messages related to remembered set write table

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2025
@openjdk
Copy link

openjdk bot commented May 13, 2025

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 13, 2025
@mlbridge
Copy link

mlbridge bot commented May 13, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2025
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2025

Going to push as commit 1569925.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2025
@openjdk openjdk bot closed this May 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2025
@openjdk
Copy link

openjdk bot commented May 13, 2025

@sashamatveev Pushed as commit 1569925.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants