-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8356819: [macos] MacSign should use "openssl" and "faketime" from Homebrew by default #25196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
|
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@sashamatveev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/integrate |
|
Going to push as commit 1569925.
Your commit was automatically rebased without conflicts. |
|
@sashamatveev Pushed as commit 1569925. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
opensslfrom macOS will ignorefaketimeand as result expired certificates will not be generated correctly. By default we should use these tools from Homebrew.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25196/head:pull/25196$ git checkout pull/25196Update a local copy of the PR:
$ git checkout pull/25196$ git pull https://git.openjdk.org/jdk.git pull/25196/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25196View PR using the GUI difftool:
$ git pr show -t 25196Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25196.diff
Using Webrev
Link to Webrev Comment