Skip to content

8356819: [macos] MacSign should use "openssl" and "faketime" from Homebrew by default #25196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sashamatveev wants to merge 1 commit into from
Closed

8356819: [macos] MacSign should use "openssl" and "faketime" from Homebrew by default #25196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,9 +1280,9 @@ static Executor security(String... args) {
// However, jtreg will alter the value of the PATH env variable and
// /usr/bin/openssl will preempt /usr/local/bin/openssl.
// To workaround this jtreg behavior support specifying path to openssl command.
private static final Path OPENSSL = Path.of(Optional.ofNullable(TKit.getConfigProperty("openssl")).orElse("openssl"));
private static final Path OPENSSL = Path.of(Optional.ofNullable(TKit.getConfigProperty("openssl")).orElse("/usr/local/bin/openssl"));

// faketime is not a standard macOS command.
// One way to get it is with Homebrew.
private static final Path FAKETIME = Path.of(Optional.ofNullable(TKit.getConfigProperty("faketime")).orElse("faketime"));
private static final Path FAKETIME = Path.of(Optional.ofNullable(TKit.getConfigProperty("faketime")).orElse("/usr/local/bin/faketime"));
}