Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8261548: ProblemList runtime/NMT/CheckForProperDetailStackTrace.java #2521

Closed

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Feb 11, 2021

Trivial, Urgent.
JDK-8261302 broke this test, and I try to find the best solution.
Since it causes a lot of noise, I'd like to add it to the problem list for now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261548: ProblemList runtime/NMT/CheckForProperDetailStackTrace.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2521/head:pull/2521
$ git checkout pull/2521

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Feb 11, 2021

Looks good!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261548: ProblemList runtime/NMT/CheckForProperDetailStackTrace.java

Reviewed-by: jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 11, 2021
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Feb 11, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2021

@tstuefe Pushed as commit 837bd89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tstuefe tstuefe deleted the JDK-8261548-problemlist-nmt-test branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants