-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8356924: RISC-V: Clean up cost for vector instructions #25221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
|
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@feilongjiang, @RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@DingliZhang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
zifeihan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
feilongjiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
RealFYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks all for the review. |
|
@DingliZhang |
|
/sponsor |
|
Going to push as commit 108e454.
Your commit was automatically rebased without conflicts. |
|
@feilongjiang @DingliZhang Pushed as commit 108e454. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As mentioned in https://bugs.openjdk.org/browse/JDK-8285790 regarding the ARM64 vector instruct modifications:
Since the new rules are unique and setting different "ins_cost" makes no sense, we have switched to using the default cost.
Currently, there is a similar situation on RISC-V. Over half of the instructions in riscv_v.ad do not include ins_cost definitions. Additionally, as RVV nodes are also unique, we can unify the format by removing these ins_cost entries from riscv_v.ad.
Testing
qemu-system 9.2.3 with UseRVV (ubuntu24.10):
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25221/head:pull/25221$ git checkout pull/25221Update a local copy of the PR:
$ git checkout pull/25221$ git pull https://git.openjdk.org/jdk.git pull/25221/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25221View PR using the GUI difftool:
$ git pr show -t 25221Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25221.diff
Using Webrev
Link to Webrev Comment