Skip to content

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented May 14, 2025

As mentioned in https://bugs.openjdk.org/browse/JDK-8285790 regarding the ARM64 vector instruct modifications:
Since the new rules are unique and setting different "ins_cost" makes no sense, we have switched to using the default cost.

Currently, there is a similar situation on RISC-V. Over half of the instructions in riscv_v.ad do not include ins_cost definitions. Additionally, as RVV nodes are also unique, we can unify the format by removing these ins_cost entries from riscv_v.ad.

Testing

qemu-system 9.2.3 with UseRVV (ubuntu24.10):

  • Run test/jdk/jdk/incubator/vector (fastdebug)
  • Run test/hotspot/jtreg/compiler/vectorapi (fastdebug)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356924: RISC-V: Clean up cost for vector instructions (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25221/head:pull/25221
$ git checkout pull/25221

Update a local copy of the PR:
$ git checkout pull/25221
$ git pull https://git.openjdk.org/jdk.git pull/25221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25221

View PR using the GUI difftool:
$ git pr show -t 25221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25221.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356924: RISC-V: Clean up cost for vector instructions

Reviewed-by: fjiang, fyang, gcao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@feilongjiang, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 14, 2025
@mlbridge
Copy link

mlbridge bot commented May 14, 2025

Webrevs

Copy link
Member

@zifeihan zifeihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2025
@DingliZhang
Copy link
Member Author

Thanks all for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 21, 2025
@openjdk
Copy link

openjdk bot commented May 21, 2025

@DingliZhang
Your change (at version 44521d8) is now ready to be sponsored by a Committer.

@feilongjiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 21, 2025

Going to push as commit 108e454.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2025
@openjdk openjdk bot closed this May 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 21, 2025
@openjdk
Copy link

openjdk bot commented May 21, 2025

@feilongjiang @DingliZhang Pushed as commit 108e454.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants