Skip to content

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented May 16, 2025

Testing:

% ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational --version
openjdk 25 2025-09-16
OpenJDK Runtime Environment (fastdebug build 25-make-genshen-non-experimental)
OpenJDK 64-Bit Server VM (fastdebug build 25-make-genshen-non-experimental, mixed mode)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8354079 to be approved
  • Commit message must refer to an issue
  • Change requires a JEP request to be targeted

Issues

  • JDK-8354078: Implement JEP 521: Generational Shenandoah (Enhancement - P4)
  • JDK-8356990: JEP 521: Generational Shenandoah (JEP)
  • JDK-8354079: JEP 521: Shenandoah: Make the generational mode be non-experimental (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25270/head:pull/25270
$ git checkout pull/25270

Update a local copy of the PR:
$ git checkout pull/25270
$ git pull https://git.openjdk.org/jdk.git pull/25270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25270

View PR using the GUI difftool:
$ git pr show -t 25270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25270.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354078: Implement JEP 521: Generational Shenandoah

Reviewed-by: ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 162 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break out the production bubbly! 🍾

Reviewed!

@ysramakrishna
Copy link
Member

Just noticed that gc/shenandoah/options/TestModeUnlock.java needs to be taught that "generational" is no longer experimental. It's failing in the GHA tests.

@rkennke
Copy link
Contributor

rkennke commented May 19, 2025

Many tests specify -XX:+UseExperimentalVMOptions to be able to use generational mode. Those -XX:+UseExperimentalVMOptions should be removed.

@earthling-amzn earthling-amzn changed the title 8354078: Shenandoah: Make the generational mode be non-experimental (implementation) 8354078: Implement JEP 521: Generational Shenandoah May 19, 2025
Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rkennke
Copy link
Contributor

rkennke commented May 21, 2025

/jep JEP-521

@openjdk
Copy link

openjdk bot commented May 21, 2025

@rkennke
This pull request will not be integrated until the JEP-521 has been targeted.

@openjdk openjdk bot added jep ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration jep labels May 21, 2025
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2025

Going to push as commit 2e8b195.
Since your change was applied there have been 166 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2025
@openjdk openjdk bot closed this May 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@earthling-amzn Pushed as commit 2e8b195.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@earthling-amzn earthling-amzn deleted the make-genshen-non-experimental branch October 7, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants