Skip to content

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented May 17, 2025

For the ratio behind this please see the companion CSR: https://bugs.openjdk.org/browse/JDK-8357180.

We plan to deprecate this in JDK 25 and to remove it in JDK 26.

This patch just writes a deprecation message to stderr:

08:46:38 thomas@starfish java -Djdk.lang.Process.launchMechanism=VFORK SimpleSpawn ls
VFORK MODE DEPRECATED
The VFORK launch mechanism has been deprecated for being dangerous.
It will be removed in a future java version. Either remove the
jdk.lang.Process.launchMechanism property (preferred) or use FORK mode
instead (-Djdk.lang.Process.launchMechanism=FORK).
...

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8357180 to be approved

Issues

  • JDK-8357179: Deprecate VFORK launch mechanism from Process implementation (linux) (Enhancement - P3)
  • JDK-8357180: Deprecate VFORK launch mechanism from Process implementation (linux) (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25282/head:pull/25282
$ git checkout pull/25282

Update a local copy of the PR:
$ git checkout pull/25282
$ git pull https://git.openjdk.org/jdk.git pull/25282/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25282

View PR using the GUI difftool:
$ git pr show -t 25282

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25282.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2025

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357179: Deprecate VFORK launch mechanism from Process implementation (linux)

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8357179: Deprecate VFORK launch mechanism from Process implementation (linux) 8357179: Deprecate VFORK launch mechanism from Process implementation (linux) May 17, 2025
@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 17, 2025
@openjdk
Copy link

openjdk bot commented May 17, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 17, 2025
@tstuefe tstuefe marked this pull request as ready for review May 17, 2025 06:52
@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2025
@mlbridge
Copy link

mlbridge bot commented May 17, 2025

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks

System.err.println("The VFORK launch mechanism has been deprecated for being dangerous.\n" +
"It will be removed in a future java version. Either remove the\n" +
"jdk.lang.Process.launchMechanism property (preferred) or use FORK mode\n" +
"instead (-Djdk.lang.Process.launchMechanism=FORK).");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay although I could imagine someone wanting to replace this with a text block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, changed to string block

@RogerRiggs
Copy link
Contributor

Looks good, also reviewed the CSR, it can be finalized.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 20, 2025
@tstuefe
Copy link
Member Author

tstuefe commented May 21, 2025

Thanks all
/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2025

Going to push as commit 74fc4e4.
Since your change was applied there have been 55 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2025
@openjdk openjdk bot closed this May 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2025
@openjdk
Copy link

openjdk bot commented May 21, 2025

@tstuefe Pushed as commit 74fc4e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev
Copy link
Member

VFORK deprecation sneaked up on me. I filed JDK-8357436 to amend jspawnhelper warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants