Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java #2531

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 11, 2021

A trivial fix to ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java
in order to reduce noise in the JDK17 CI.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2531/head:pull/2531
$ git checkout pull/2531

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 11, 2021

/label add core-libs
/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the core-libs label Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk openjdk bot added the hotspot-runtime label Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Feb 11, 2021
@openjdk openjdk bot added the rfr label Feb 11, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Looks good and trivial.
Thanks, Harold

@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 11, 2021

@hseigel - Thanks for the fast review!

/integrate

@openjdk openjdk bot closed this Feb 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@dcubed-ojdk Pushed as commit 75c8489.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8261604 branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot-runtime integrated
2 participants