8357287: Unify usage of ICC profile "header size" constants in CMM-related code

[mrserb]

Small unification of "header size" constants, as of now the CMM code uses:

1. sun.java2d.cmm.ProfileDataVerifier.HEADER_SIZE introduced in JDK-8013430
2. java.awt.color.ICC_Profile.HEADER_SIZE introduced in JDK-8347377
3. Hardcoded literal 128

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357287: Unify usage of ICC profile "header size" constants in CMM-related code (Enhancement - P5)

Reviewers

• Harshitha Onkar (@honkar-jdk - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25313/head:pull/25313
$ git checkout pull/25313

Update a local copy of the PR:
$ git checkout pull/25313
$ git pull https://git.openjdk.org/jdk.git pull/25313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25313

View PR using the GUI difftool:
$ git pr show -t 25313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25313.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357287: Unify usage of ICC profile "header size" constants in CMM-related code

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• afcbf6b: 8357173: Split jtreg test group jdk tier3
• 8153683: 8345826: Do not automatically resolve jdk.internal.vm.ci when libgraal is used
• 400c935: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk
• ... and 37 more: https://git.openjdk.org/jdk/compare/890456f0f78cc37c72b438a50ddf2605e1dfd91b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (876811de)

[honkar-jdk]

LGTM

[mrserb]

/integrate

[openjdk]

Going to push as commit 68c1d30.
Since your change was applied there have been 47 commits pushed to the master branch:

• 3bebb1f: 8357504: Refactor the assignment of loader bits in InstanceKlassFlags
• ee68914: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
• b685ea5: 8357511: [BACKOUT] 8357048: RunTest variables should always be assigned
• ... and 44 more: https://git.openjdk.org/jdk/compare/890456f0f78cc37c72b438a50ddf2605e1dfd91b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 68c1d30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.