8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

[manukumarvs]

There are some compilation failures noticed in the recently open sourced test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to missing import statements and a missing dependency file MenuItemTest.java.

Fix: I have added the required import statements and added the code-piece from MenuItemTest.java as a method getMenuItemTestFrame().

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (Bug - P3)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25319/head:pull/25319
$ git checkout pull/25319

Update a local copy of the PR:
$ git checkout pull/25319
$ git pull https://git.openjdk.org/jdk.git pull/25319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25319

View PR using the GUI difftool:
$ git pr show -t 25319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25319.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• 12efc1f: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently
• 428d33e: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual
• 1e57648: 8350457: Implement JEP 519: Compact Object Headers
• ... and 53 more: https://git.openjdk.org/jdk/compare/e961b13cd68bc352b86af17c7e53df8537519beb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 08: Full - Incremental (36338cac)
• 07: Full - Incremental (64134a5e)
• 06: Full - Incremental (db537cb8)
• 05: Full - Incremental (b04155cd)
• 04: Full - Incremental (996bc9e3)
• 03: Full - Incremental (22b05bbd)
• 02: Full - Incremental (098ea0de)
• 01: Full - Incremental (1f027147)
• 00: Full (adf3a94d)

[aivanov-jdk]

I see that MenuItemTest class exists in bug4729669.java:

jdk/test/jdk/javax/swing/JMenuItem/bug4729669.java

Line 80 in e961b13

class MenuItemTest {

Is it similar to the one that you copied?

If that MenuItemTest class is identical, I suggest moving both tests into a subdirectory and promoting MenuItemTest into a public class in that subdirectory which is located in its own .java file.

[manukumarvs]

I see that MenuItemTest class exists in bug4729669.java:

jdk/test/jdk/javax/swing/JMenuItem/bug4729669.java

Line 80 in e961b13

class MenuItemTest {

Is it similar to the one that you copied?

If that MenuItemTest class is identical, I suggest moving both tests into a subdirectory and promoting MenuItemTest into a public class in that subdirectory which is located in its own .java file.

No, these are no exactly the same, the doMenuItemTest(boolean isLeft) method in bug4729669.java has only one parameter, but the doMenuItemTest(boolean isLeft, String lafName, int frameY) method has three parameters in bug6197830.java.

[aivanov-jdk]

I see that MenuItemTest class exists in bug4729669.java:

jdk/test/jdk/javax/swing/JMenuItem/bug4729669.java

Line 80 in e961b13

class MenuItemTest {

Is it similar to the one that you copied?
If that MenuItemTest class is identical, I suggest moving both tests into a subdirectory and promoting MenuItemTest into a public class in that subdirectory which is located in its own .java file.

No, these are no exactly the same, the doMenuItemTest(boolean isLeft) method in bug4729669.java has only one parameter, but the doMenuItemTest(boolean isLeft, String lafName, int frameY) method has three parameters in bug6197830.java.

Can they be merged together?

If possible, I'd like to eliminate code duplication and extract common code.

[aivanov-jdk]

I see that MenuItemTest class exists in bug4729669.java:

jdk/test/jdk/javax/swing/JMenuItem/bug4729669.java

Line 80 in e961b13

class MenuItemTest {

Is it similar to the one that you copied?
If that MenuItemTest class is identical, I suggest moving both tests into a subdirectory and promoting MenuItemTest into a public class in that subdirectory which is located in its own .java file.

No, these are no exactly the same, the doMenuItemTest(boolean isLeft) method in bug4729669.java has only one parameter, but the doMenuItemTest(boolean isLeft, String lafName, int frameY) method has three parameters in bug6197830.java.

Can they be merged together?

If possible, I'd like to eliminate code duplication and extract common code.

The only difference is the Look-and-Feel parameter, which can be abstracted by pulling out common code.

Then frameY is used to position the test frame. It's not needed if PassFailJFrame.Builder.positionTestUIBottomRowCentered or positionTestUIRightColumnCentered are used.

For the case where multiple L&Fs are tested, a custom layout could be implemented to position test windows in two columns and two rows, which is easy with WindowLayouts.

Is Motif L&F still supported? I guess it is but it's deprecated.

jdk/src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java

Lines 51 to 57 in ab985a7

	* @deprecated The Motif Look and Feel is deprecated with the intent to remove
	* it in some future release. It is recommended to use
	* {@link javax.swing.plaf.metal.MetalLookAndFeel} instead.
	*/
	@SuppressWarnings("serial") // Superclass is not serializable across versions
	@Deprecated(since="13", forRemoval=true)
	public class MotifLookAndFeel extends BasicLookAndFeel

[manukumarvs]

I see that MenuItemTest class exists in bug4729669.java:

jdk/test/jdk/javax/swing/JMenuItem/bug4729669.java

Line 80 in e961b13

class MenuItemTest {

Is it similar to the one that you copied?
If that MenuItemTest class is identical, I suggest moving both tests into a subdirectory and promoting MenuItemTest into a public class in that subdirectory which is located in its own .java file.

No, these are no exactly the same, the doMenuItemTest(boolean isLeft) method in bug4729669.java has only one parameter, but the doMenuItemTest(boolean isLeft, String lafName, int frameY) method has three parameters in bug6197830.java.

Can they be merged together?

If possible, I'd like to eliminate code duplication and extract common code.

Yes, I can try that.

[aivanov-jdk]

There are still unresolved comments, and I added new ones.

[aivanov-jdk]

I'm for propagating the exception if setting L&F fails.

[aivanov-jdk]

Drop setLocation and setVisible as well as frameY parameter.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 36338ca) is now ready to be sponsored by a Committer.

[sendaoYan]

/sponsor

[openjdk]

Going to push as commit a94d1a0.
Since your change was applied there have been 65 commits pushed to the master branch:

• 8402469: 8355236: AOT Assembly crash with unregistered class and -Xlog:cds+resolve=trace
• 796ec5e: 8353741: Eliminate table lookup in UUID.toString
• fdda766: 8356814: LineBreakMeasurer.nextLayout() slower than necessary when no break needed
• ... and 62 more: https://git.openjdk.org/jdk/compare/e961b13cd68bc352b86af17c7e53df8537519beb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan @manukumarvs Pushed as commit a94d1a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.