Skip to content

8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" #25338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" #25338

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
933b958
Refactor nmethod make_not_entrant reason
JohnTortugo Apr 16, 2025
b3bb436
Address PR feedback: modify emum to be scoped.
JohnTortugo Jun 3, 2025
fa77be5
Address PR feedback: more refactoring / renamings
JohnTortugo Jun 3, 2025
dc3aa2c
Fix spacing, fix build.
JohnTortugo Jun 3, 2025
6af5959
Revert change to attribute of make_not_entrant element
JohnTortugo Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/code/nmethod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,7 +1968,7 @@ void nmethod::log_state_change(ChangeReason change_reason) const {
if (LogCompilation) {
if (xtty != nullptr) {
ttyLocker ttyl; // keep the following output all in one block
xtty->begin_elem("make_not_entrant thread='%zu' change_reason='%s'",
xtty->begin_elem("make_not_entrant thread='%zu' reason='%s'",
os::current_thread_id(), change_reason_to_string(change_reason));
log_identity(xtty);
xtty->stamp();
Expand Down