8357424: [JVMCI] Avoid incrementing decompilation count for hosted compiled nmethod

[mur47x111]

Hosted Truffle compilations are installed on the OptimizedCallTarget#profiledPERoot method. Any deoptimization contributes to its decompile count, which can easily exceed the PerMethodRecompilationCutoff threshold, permanently preventing highest tier compilation on this method. This PR exempts hosted compilations from this cutoff by ensuring their decompile count is not incremented for hosted compiled nmethods.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357424: [JVMCI] Avoid incrementing decompilation count for hosted compiled nmethod (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)
• Cesar Soares Lucas (@JohnTortugo - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25356/head:pull/25356
$ git checkout pull/25356

Update a local copy of the PR:
$ git checkout pull/25356
$ git pull https://git.openjdk.org/jdk.git pull/25356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25356

View PR using the GUI difftool:
$ git pr show -t 25356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25356.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357424: [JVMCI] Avoid incrementing decompilation count for hosted compiled nmethod

Reviewed-by: dnsimon, never, cslucas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 5e30bf6: 8360116: Add support for AVX10 floating point minmax instruction
• c503705: 8360090: [TEST] RISC-V: disable some cds tests on qemu
• c460f84: 8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix)
• ... and 6 more: https://git.openjdk.org/jdk/compare/0f1cd987b3520eaeab31e9faf782d6f81050803a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mur47x111 The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 09: Full - Incremental (d6221921)
• 08: Full - Incremental (022546a0)
• 07: Full - Incremental (fb32a8c7)
• 06: Full - Incremental (f253c0a8)
• 05: Full - Incremental (9d24428e)
• 04: Full - Incremental (57fe5307)
• 03: Full - Incremental (b72213ae)
• 02: Full - Incremental (e66c16d1)
• 01: Full - Incremental (ef4a4c98)
• 00: Full (8fcd7104)

[dougxc]

Looks good.

[tkrodriguez]

I think there are two levels of counters that we might want to disable. We definitely want to stop deopts and recompilations from marking the method not compilable which the current change does. Additionally JVMCIRuntime::register_method will perform this logic if validate_compile_task_dependencies fails and I don't think we want that. I think the new !is_default guard idiom should be in a helper like nmethod::is_jvmci_hosted. Do we use the hosted language elsewhere?

The second level is to stop all counter updates in hosted compiles, for similar reasons. Those updates won't lead to disabling compilation but they will quickly lead to saturating of all the counters which is fairly pointless but probably benign. This would be done by setting update_trap_state to false for hosted nmethods. That also has the effect of keeping inc_recompile_count false. I think that's the right thing to do but I'd want to make sure that we test truffle workloads with those changes before making that change to make sure there isn't some subtle problem with that change.

[mur47x111]

@tkrodriguez by stop all counter updates in hosted compiles you mean the trap-related counters, right?

[tkrodriguez]

Yes. Any update to the MDO for hosted compiles doesn't seem useful I think.

[tkrodriguez]

Looks great.

[JohnTortugo]

LGTM. Thanks.

[mur47x111]

Thanks for the review! Passed Tier1-3
/integrate

[openjdk]

Going to push as commit ea86a20.
Since your change was applied there have been 9 commits pushed to the master branch:

• 5e30bf6: 8360116: Add support for AVX10 floating point minmax instruction
• c503705: 8360090: [TEST] RISC-V: disable some cds tests on qemu
• c460f84: 8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix)
• ... and 6 more: https://git.openjdk.org/jdk/compare/0f1cd987b3520eaeab31e9faf782d6f81050803a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mur47x111 Pushed as commit ea86a20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.