8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException #25366

alexmenkov · 2025-05-21T20:17:09Z

The change fixes failure of vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java test.
The test was problem-listed in jdk 11 due intermittent timeouts, but in jdk15-16 changes in nsk framework made the test fail 100% (it wasn't noticed as the test was problemlisted)
The problem is attach045 has "target" parameter which contain class name and arguments (all other tests have only class name), and value of the argument is passed in surrounding quotes, so target application fails with ClassNotFoundException.
Now I cannot reproduce original test failure, so removing the test from problemlist

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException (Bug - P4)

Reviewers

Leonid Mesnik (@lmesnik - Reviewer)
Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25366/head:pull/25366
$ git checkout pull/25366

Update a local copy of the PR:
$ git checkout pull/25366
$ git pull https://git.openjdk.org/jdk.git pull/25366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25366

View PR using the GUI difftool:
$ git pr show -t 25366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25366.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-05-21T20:17:59Z

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-05-21T20:18:53Z

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException

Reviewed-by: lmesnik, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 135 new commits pushed to the master branch:

070c84c: 8357178: Simplify Class::componentType
6674771: 8357468: [asan] heap buffer overflow reported in PcDesc::pc_offset() pcDesc.hpp:57
236e1b6: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402
... and 132 more: https://git.openjdk.org/jdk/compare/efdbb6afce4116140c066641128264ab42697912...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-05-21T20:19:50Z

@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
graal
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

alexmenkov · 2025-05-21T20:20:58Z

/label add serviceability

openjdk · 2025-05-21T20:21:37Z

@alexmenkov
The serviceability label was successfully added.

mlbridge · 2025-05-21T20:24:33Z

Webrevs

00: Full (5b3138b3)

lmesnik

As I understand, this fix is not related to timeout. So test is going to fail. It might be makes a sense to remove it from problemlist to see how it works. However better to rename PR summary.

lmesnik · 2025-05-22T19:51:43Z

test/hotspot/jtreg/vmTestbase/nsk/share/aod/AODRunnerArgParser.java

        }

-        return options.getProperty(TARGET_APP_PARAM);
+        String target = options.getProperty(TARGET_APP_PARAM);


I think it is better to remove -classPath from parameters and
use
${test.class.path}
directly in the test.

The test is run by nsk.share.aod.AODTestRunner which runs test app specified by "target" argument.
Target apps have no system properties like test.class.path

Thanks for explanation.

alexmenkov · 2025-05-22T20:33:21Z

As I understand, this fix is not related to timeout. So test is going to fail. It might be makes a sense to remove it from problemlist to see how it works. However better to rename PR summary.

Oh, right. It's socket timeout, not the test timeout. Renamed JBS issue

sspitsyn · 2025-05-23T17:19:59Z

Oh, right. It's socket timeout, not the test timeout. Renamed JBS issue

Nit: Would it better to replace: "fails after ClassNotFoundException" => "fails with ClassNotFoundException" ?

sspitsyn · 2025-05-23T17:26:33Z

This test was marked in ProblemList with https://bugs.openjdk.org/browse/JDK-8202971.
The test was intermittently failing with timeouts in JDK 11.
Does removing it from ProblemList mean the test does not fail with the symptom of 8202971 anymore?
I'm double-checking because I'm not sure I fully understand the PR description.

alexmenkov · 2025-05-23T17:52:28Z

Oh, right. It's socket timeout, not the test timeout. Renamed JBS issue

Nit: Would it better to replace: "fails after ClassNotFoundException" => "fails with ClassNotFoundException" ?

Actually It fails with SocketTimeoutException. The test waits target process to connect, but it happens after target app fails with ClassNotFoundException

alexmenkov · 2025-05-23T17:54:07Z

This test was marked in ProblemList with https://bugs.openjdk.org/browse/JDK-8202971. The test was intermittently failing with timeouts in JDK 11. Does removing it from ProblemList mean the test does not fail with the symptom of 8202971 anymore? I'm double-checking because I'm not sure I fully understand the PR description.

I was not able to reproduce 8202971 (400 runs)

sspitsyn · 2025-05-23T18:30:15Z

Actually It fails with SocketTimeoutException. The test waits target process to connect, but it happens after target app fails with ClassNotFoundException

Okay, thanks.

I was not able to reproduce 8202971 (400 runs)

Okay, thanks.

sspitsyn

Looks good.

alexmenkov · 2025-05-27T23:22:42Z

/integrate

openjdk · 2025-05-27T23:23:30Z

Going to push as commit c110623.
Since your change was applied there have been 178 commits pushed to the master branch:

f25f4a3: 8349665: Make clean removes module-deps.gmk
2e8b195: 8354078: Implement JEP 521: Generational Shenandoah
11ad173: 8354944: Remove unnecessary PartiallyOrderedSet.nodes
... and 175 more: https://git.openjdk.org/jdk/compare/efdbb6afce4116140c066641128264ab42697912...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-05-27T23:23:36Z

@alexmenkov Pushed as commit c110623.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fix

5b3138b

openjdk bot added the rfr Pull request is ready for review label May 21, 2025

openjdk bot added the serviceability serviceability-dev@openjdk.org label May 21, 2025

lmesnik reviewed May 22, 2025

View reviewed changes

lmesnik suggested changes May 22, 2025

View reviewed changes

alexmenkov changed the title ~~8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java times out after ClassNotFoundException~~ 8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException May 22, 2025

sspitsyn approved these changes May 23, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 23, 2025

lmesnik approved these changes May 24, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label May 27, 2025

openjdk bot closed this May 27, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025

alexmenkov deleted the attach045 branch May 28, 2025 00:35

8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException #25366

8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException #25366

Uh oh!

Conversation

alexmenkov commented May 21, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 21, 2025

Uh oh!

openjdk bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented May 21, 2025

Uh oh!

alexmenkov commented May 21, 2025

Uh oh!

openjdk bot commented May 21, 2025

Uh oh!

mlbridge bot commented May 21, 2025

Webrevs

Uh oh!

lmesnik left a comment

Choose a reason for hiding this comment

Uh oh!

lmesnik May 22, 2025

Choose a reason for hiding this comment

Uh oh!

alexmenkov May 22, 2025

Choose a reason for hiding this comment

Uh oh!

lmesnik May 24, 2025

Choose a reason for hiding this comment

Uh oh!

alexmenkov commented May 22, 2025

Uh oh!

sspitsyn commented May 23, 2025

Uh oh!

sspitsyn commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexmenkov commented May 23, 2025

Uh oh!

alexmenkov commented May 23, 2025

Uh oh!

sspitsyn commented May 23, 2025

Uh oh!

sspitsyn left a comment

Choose a reason for hiding this comment

Uh oh!

alexmenkov commented May 27, 2025

Uh oh!

openjdk bot commented May 27, 2025

Uh oh!

openjdk bot commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

alexmenkov commented May 21, 2025 •

edited by openjdk bot

Loading

openjdk bot commented May 21, 2025 •

edited

Loading

sspitsyn commented May 23, 2025 •

edited

Loading