8357506: [JVMCI] Consolidate eager JVMCI initialization code

[dougxc]

While working on JDK-8357135, I was reminded that some of the code implementing eager JVMCI compiler initialization (i.e. -XX:+EagerJVMCI) is in helper methods such as JVMCIRuntime::call_getCompiler that sound general purpose but are only used for eager JVMCI compiler initialization. This PR inlines JVMCIRuntime::call_getCompiler and renames JVMCI::initialize_compiler to initialize_compiler_in_create_vm to make its single use case clearer.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357506: [JVMCI] Consolidate eager JVMCI initialization code (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Yudi Zheng (@mur47x111 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25369/head:pull/25369
$ git checkout pull/25369

Update a local copy of the PR:
$ git checkout pull/25369
$ git pull https://git.openjdk.org/jdk.git pull/25369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25369

View PR using the GUI difftool:
$ git pr show -t 25369

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25369.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357506: [JVMCI] Consolidate eager JVMCI initialization code

Reviewed-by: kvn, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 9d9e41f: 8356894: Adjust CreateSymbols to properly handle the newly added @jdk.internal.RequiresIdentity
• 99e0130: 8356145: ListEnterExitTest.java fails on macos
• 1fd65b7: 8351140: RISC-V: Intrinsify Unsafe::setMemory
• ... and 31 more: https://git.openjdk.org/jdk/compare/afcbf6b2f49c00a544e6db5b4ed9da76c0bdcba4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3b4bf20e)
• 00: Full (c069487d)

[openjdk]

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[vnkozlov]

Good.

[mur47x111]

LGTM

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit d6e4c5f.
Since your change was applied there have been 34 commits pushed to the master branch:

• 9d9e41f: 8356894: Adjust CreateSymbols to properly handle the newly added @jdk.internal.RequiresIdentity
• 99e0130: 8356145: ListEnterExitTest.java fails on macos
• 1fd65b7: 8351140: RISC-V: Intrinsify Unsafe::setMemory
• ... and 31 more: https://git.openjdk.org/jdk/compare/afcbf6b2f49c00a544e6db5b4ed9da76c0bdcba4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit d6e4c5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.