Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8261623: reference to javac internals in Extern class #2537

Closed
wants to merge 2 commits into from

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Feb 12, 2021

Trivial patch to move some code that accesses javac-internals into the WorkArounds class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261623: reference to javac internals in Extern class

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2537/head:pull/2537
$ git checkout pull/2537

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Feb 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

hns
hns approved these changes Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261623: reference to javac internals in Extern class

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 12, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Feb 12, 2021

/integrate

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@jonathan-gibbons Since your change was applied there have been 16 commits pushed to the master branch:

  • 350303d: 8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion
  • 6475d47: 8261655: [PPC64] Build broken after JDK-8260941
  • c0e805a: 8261654: Missing license header in Signatures.java
  • b670efd: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 59b8d59: 8261481: Cannot read Kerberos settings in dynamic store on macOS Big Sur
  • 9f81ca8: 8261230: GC tracing of page sizes are wrong in a few places
  • 40ae993: 8261027: AArch64: Support for LSE atomics C++ HotSpot code
  • 9ffabf3: 8252971: WindowsFileAttributes does not know about Unix domain sockets
  • 682e78e: 8261071: AArch64: Refactor interpreter native wrappers
  • ebaa58d: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/60a2072a430ef00f32ab81651781445d0958c027...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3aa1b4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the javac.code branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated javadoc
2 participants