Skip to content

8357563: Shenandoah headers leak un-prefixed defines #25392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefank wants to merge 1 commit into from
Closed

8357563: Shenandoah headers leak un-prefixed defines #25392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,19 @@ enum class ShenandoahFreeSetPartitionId : uint8_t {
NotFree // Region is in no free set: it has no available memory
};

// We do not maintain counts, capacity, or used for regions that are not free. Informally, if a region is NotFree, it is
// in no partition. NumPartitions represents the size of an array that may be indexed by Mutator or Collector.
#define NumPartitions (ShenandoahFreeSetPartitionId::NotFree)
#define IntNumPartitions int(ShenandoahFreeSetPartitionId::NotFree)
#define UIntNumPartitions uint(ShenandoahFreeSetPartitionId::NotFree)

// ShenandoahRegionPartitions provides an abstraction to help organize the implementation of ShenandoahFreeSet. This
// class implements partitioning of regions into distinct sets. Each ShenandoahHeapRegion is either in the Mutator free set,
// the Collector free set, or in neither free set (NotFree). When we speak of a "free partition", we mean partitions that
// for which the ShenandoahFreeSetPartitionId is not equal to NotFree.
class ShenandoahRegionPartitions {

private:
// We do not maintain counts, capacity, or used for regions that are not free. Informally, if a region is NotFree, it is
// in no partition. NumPartitions represents the size of an array that may be indexed by Mutator or Collector.
static constexpr ShenandoahFreeSetPartitionId NumPartitions = ShenandoahFreeSetPartitionId::NotFree;
static constexpr int IntNumPartitions = int(ShenandoahFreeSetPartitionId::NotFree);
static constexpr uint UIntNumPartitions = uint(ShenandoahFreeSetPartitionId::NotFree);

const ssize_t _max; // The maximum number of heap regions
const size_t _region_size_bytes;
const ShenandoahFreeSet* _free_set;
Expand Down