Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag #254

Closed
wants to merge 8 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Sep 18, 2020

ShenandoahSelfFixing flag is currently only honored by C2, not runtime barrier. Runtime barrier should check the check too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag

Download

$ git fetch https://git.openjdk.java.net/jdk pull/254/head:pull/254
$ git checkout pull/254

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@zhengyu123 The following labels will be automatically applied to this pull request: hotspot shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of unrelated changes in that patch, all that thread/NMT stuff...

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

⚠️ @zhengyu123 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@zhengyu123
Copy link
Contributor Author

Messed up with branching, will re-do.

@zhengyu123 zhengyu123 closed this Sep 18, 2020
@zhengyu123 zhengyu123 deleted the JDK-8253361 branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org
2 participants