8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

[tschatzl]

Hi all,

can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on CardTable::scanned_concurrently() just removed in JDK-8260941 ?

Thanks,
Thomas

Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Author)
• Stefan Johansson (@kstefanj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2541/head:pull/2541
$ git checkout pull/2541

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (85ea705)

[shipilev]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewed-by: shade, ayang, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
• d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
• fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
• d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
• 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
• 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
• 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
• 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/9c0ec8d8485e1f1e44aee9bbde711143508759aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

Looks good.

[tschatzl]

Thanks @shipilev , @albertnetymk , @kstefanj for your reviews.

/integrate

[openjdk]

@tschatzl Since your change was applied there have been 53 commits pushed to the master branch:

• b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
• d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
• fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
• d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
• 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
• 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
• 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
• 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/9c0ec8d8485e1f1e44aee9bbde711143508759aa...master

Your commit was automatically rebased without conflicts.

Pushed as commit a930870.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.