8357654: [BACKOUT] JDK-8343580: Type error with inner classes of generic classes in functions generic by outer

[biboudis]

While the original fix, addresses the type checking issue, we believe its worth-backing out this change to investigate the implications of the fix to the generated code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357654: [BACKOUT] JDK-8343580: Type error with inner classes of generic classes in functions generic by outer (Bug - P4)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)
• Chen Liang (@liach - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25417/head:pull/25417
$ git checkout pull/25417

Update a local copy of the PR:
$ git checkout pull/25417
$ git pull https://git.openjdk.org/jdk.git pull/25417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25417

View PR using the GUI difftool:
$ git pr show -t 25417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25417.diff

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mcimadamore]

Looks good - thanks

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357654: [BACKOUT] JDK-8343580: Type error with inner classes of generic classes in functions generic by outer

Reviewed-by: mcimadamore, liach, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6a07820: 8357285: JSR166 Test case testShutdownNow_delayedTasks failed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[biboudis]

/integrate

[openjdk]

Going to push as commit 90e076b.
Since your change was applied there has been 1 commit pushed to the master branch:

• 6a07820: 8357285: JSR166 Test case testShutdownNow_delayedTasks failed

Your commit was automatically rebased without conflicts.

[openjdk]

@biboudis Pushed as commit 90e076b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (87518a8d)