8357689: Refactor JVMCI to enable replay compilation in Graal #25433

pecimuth · 2025-05-24T16:49:23Z

This PR introduces a few minor JVMCI refactorings to make replay compilation possible in the Graal compiler.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8357689: Refactor JVMCI to enable replay compilation in Graal (Enhancement - P4)

Reviewers

Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25433/head:pull/25433
$ git checkout pull/25433

Update a local copy of the PR:
$ git checkout pull/25433
$ git pull https://git.openjdk.org/jdk.git pull/25433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25433

View PR using the GUI difftool:
$ git pr show -t 25433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25433.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-05-24T16:49:58Z

👋 Welcome back pecimuth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-05-24T16:50:18Z

@pecimuth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357689: Refactor JVMCI to enable replay compilation in Graal

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

e024568: 8361532: RISC-V: Several vector tests fail after JDK-8354383
4761479: 8238687: Investigate memory uncommit during young collections in G1
fe26467: 8361363: ShenandoahAsserts::print_obj() does not work for forwarded objects and UseCompactObjectHeaders
... and 32 more: https://git.openjdk.org/jdk/compare/4df9c873452293ccde3c7dbcd64e1ced6b6af52e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-05-24T16:50:44Z

@pecimuth The following labels will be automatically applied to this pull request:

graal
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

dougxc · 2025-05-27T12:10:29Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/BytecodeFrame.java

+     *
+     * @return a copy of the slot kinds array
+     */
+    public JavaKind[] getSlotKinds() {


Keep in mind that slotKinds is being converted to a List. In that context, can we return the list without making a copy? Or is the caller expected to be able to mutate the return value?

Applied the changes provided by @mur47x111.

dougxc · 2025-05-27T12:14:42Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/VirtualObject.java

        if (o == this) {
            return true;
        }
        if (o instanceof VirtualObject) {


Rename l to that and use pattern instanceof:

Suggested change

if (o instanceof VirtualObject) {

if (o instanceof VirtualObject that) {

dougxc · 2025-05-27T12:19:03Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/VirtualObject.java

+     * @return a copy of the array containing the Java kinds of the values or {@code null} if the
+     *         values have not been initialized.
+     */
+    public JavaKind[] getSlotKinds() {


Same comments as for BytecodeFrame.getSlotKinds. This applies to all other non-primitive array return values added by this PR.

I left Object[] as the return value of EncodedSpeculationReason#getReason since the array could contain null elements, preventing the use of an immutable list like everywhere else.

Edit: SharedSecrets.getJavaUtilCollectionAccess().listFromTrustedArrayNullsAllowed could work here.

dougxc · 2025-05-27T12:21:52Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotCompiledCode.java

+    /**
+     * Returns a copy of the array of {@link ResolvedJavaMethod} objects representing the methods
+     * whose bytecodes were used as input to the compilation. If the compilation did not record
+     * method dependencies, this method returns {@code null}. Otherwise, the first element of the


null -> empty list?

mlbridge · 2025-07-07T13:07:54Z

Webrevs

pecimuth · 2025-07-07T13:42:01Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/BytecodeFrame.java

        this.duringCall = duringCall;
        this.values = values;
-        this.slotKinds = slotKinds;
+        this.slotKinds = listFromTrustedArray(slotKinds);


ImmutableCollections#listFromTrustedArray asserts that the array class is Object[].class, but the type of slotKinds is JavaKind[] - so these refactorings do not work.

dougxc

Looks good.

openjdk · 2025-07-08T17:12:50Z

⚠️ @pecimuth the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8357689
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

dougxc

Still good.

pecimuth · 2025-07-09T07:25:38Z

/integrate

openjdk · 2025-07-09T07:26:47Z

@pecimuth
Your change (at version 1b845fa) is now ready to be sponsored by a Committer.

dougxc · 2025-07-09T08:18:45Z

/sponsor

openjdk · 2025-07-09T08:19:52Z

Going to push as commit 963b83f.
Since your change was applied there have been 36 commits pushed to the master branch:

68b27b8: 8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info()
e024568: 8361532: RISC-V: Several vector tests fail after JDK-8354383
4761479: 8238687: Investigate memory uncommit during young collections in G1
... and 33 more: https://git.openjdk.org/jdk/compare/4df9c873452293ccde3c7dbcd64e1ced6b6af52e...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-07-09T08:20:07Z

@dougxc @pecimuth Pushed as commit 963b83f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels May 24, 2025

dougxc reviewed May 27, 2025

View reviewed changes

pecimuth force-pushed the JDK-8357689 branch from a1a5240 to c12f507 Compare July 7, 2025 12:51

pecimuth marked this pull request as ready for review July 7, 2025 13:03

openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025

pecimuth marked this pull request as draft July 7, 2025 13:25

openjdk bot removed the rfr Pull request is ready for review label Jul 7, 2025

pecimuth commented Jul 7, 2025

View reviewed changes

JVMCI refactorings to enable replay compilation in Graal.

c6c3bb6

pecimuth force-pushed the JDK-8357689 branch from c12f507 to c6c3bb6 Compare July 7, 2025 17:13

pecimuth marked this pull request as ready for review July 8, 2025 08:36

pecimuth requested a review from dougxc July 8, 2025 08:37

openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025

dougxc approved these changes Jul 8, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025

Remove unnecessary public modifier.

1b845fa

openjdk bot removed the ready Pull request is ready to be integrated label Jul 8, 2025

dougxc approved these changes Jul 8, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 9, 2025

openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025

openjdk bot closed this Jul 9, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 9, 2025

	if (o instanceof VirtualObject) {
	if (o instanceof VirtualObject that) {

8357689: Refactor JVMCI to enable replay compilation in Graal #25433

8357689: Refactor JVMCI to enable replay compilation in Graal #25433

Uh oh!

Conversation

pecimuth commented May 24, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 24, 2025

Uh oh!

openjdk bot commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented May 24, 2025

Uh oh!

dougxc May 27, 2025

Choose a reason for hiding this comment

Uh oh!

pecimuth Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc May 27, 2025

Choose a reason for hiding this comment

Uh oh!

dougxc May 27, 2025

Choose a reason for hiding this comment

Uh oh!

pecimuth Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc May 27, 2025

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

pecimuth Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

dougxc left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jul 8, 2025

Uh oh!

dougxc left a comment

Choose a reason for hiding this comment

Uh oh!

pecimuth commented Jul 9, 2025

Uh oh!

openjdk bot commented Jul 9, 2025

Uh oh!

dougxc commented Jul 9, 2025

Uh oh!

openjdk bot commented Jul 9, 2025

Uh oh!

openjdk bot commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

pecimuth commented May 24, 2025 •

edited by openjdk bot

Loading

openjdk bot commented May 24, 2025 •

edited

Loading

pecimuth Jul 7, 2025 •

edited

Loading

pecimuth Jul 7, 2025 •

edited

Loading

mlbridge bot commented Jul 7, 2025 •

edited

Loading