Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions #2545

Closed
wants to merge 3 commits into from

Conversation

@jaokim
Copy link
Contributor

@jaokim jaokim commented Feb 12, 2021

This fix adds a check for coarsened region in mutex guarded section, when adding a reference to a remembered set.

Haven't been able to produce a testcase -- please advice on how to, or if not necessary.

Testing:

  • hs-tier, hs-tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2545/head:pull/2545
$ git checkout pull/2545

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back jaokim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@jaokim The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Feb 12, 2021
@jaokim jaokim marked this pull request as ready for review Feb 19, 2021
@openjdk openjdk bot added the rfr label Feb 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 19, 2021

Webrevs

Loading

src/hotspot/share/gc/g1/heapRegionRemSet.cpp Outdated Show resolved Hide resolved
Loading
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@jaokim This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 535 new commits pushed to the master branch:

  • 26c1db9: 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.
  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"
  • 2b00367: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer
  • 5a25cea: 8261998: Remove unused shared entry support from utilities/hashtable
  • ... and 525 more: https://git.openjdk.java.net/jdk/compare/b8ef2bad527734f36b431da22d3c12a3db901466...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Feb 22, 2021
@jaokim
Copy link
Contributor Author

@jaokim jaokim commented Feb 22, 2021

Thank you @albertnetymk and @tschatzl for review!

/integrate

Loading

@openjdk openjdk bot added the sponsor label Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@jaokim
Your change (at version 4bc0f4b) is now ready to be sponsored by a Committer.

Loading

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Feb 22, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@tschatzl @jaokim Since your change was applied there have been 542 commits pushed to the master branch:

  • d7eebda: 8261391: ZGC crash - SEGV in RevokeOneBias::do_thread
  • 5b7b18c: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
  • 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
  • 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
  • e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
  • 6b7575b: 8228748: Remove GCLocker::_doing_gc
  • c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
  • 26c1db9: 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.
  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • ... and 532 more: https://git.openjdk.java.net/jdk/compare/b8ef2bad527734f36b431da22d3c12a3db901466...master

Your commit was automatically rebased without conflicts.

Pushed as commit a6a7e43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@jaokim jaokim deleted the JDK-8242032 branch Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants